Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): set http timeout 10 sec #1154

Merged
merged 2 commits into from
Jan 30, 2021
Merged

fix(report): set http timeout 10 sec #1154

merged 2 commits into from
Jan 30, 2021

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Jan 28, 2021

What did you implement:

Vuls send HTTP requests when reporting, e.g., GitHub Security Alerts, go-cve as http server mode, etc.
But, Vuls hadn't set the HTTP timeout, so Vuls was waiting forever for the http response.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

./vuls report works fine

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe merged commit 4dcbd86 into master Jan 30, 2021
@kotakanbe kotakanbe deleted the timeout branch January 30, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant