Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ms): remove duplicate advisories #1490

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

It is rare for the same KB to be added to the distro advisory by multiple products because the KB is basically filtered by Product. However, when scanning without determining the OS, duplicate distro advisories may be added. This PR corrects this problem and makes the KBs added to the distro advisory unique.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Jul 13, 2022
@MaineK00n MaineK00n marked this pull request as ready for review July 13, 2022 21:38
Copy link
Collaborator

@sadayuki-matsuno sadayuki-matsuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadayuki-matsuno sadayuki-matsuno merged commit d1a617c into master Jul 14, 2022
@sadayuki-matsuno sadayuki-matsuno deleted the MaineK00n/uniq-advisory branch July 14, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants