fix(detector/suse): support when advisory.cves has both NVD and SUSE evaluations #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaineK00n
force-pushed
the
MaineK00n/suse-cves
branch
2 times, most recently
from
f80e7a5
to
6a67943
Compare
shino
reviewed
Apr 23, 2024
MaineK00n
force-pushed
the
MaineK00n/suse-cves
branch
from
6a67943
to
2820142
Compare
shino
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.
What did you implement:
In the recent SUSE OVAL, it seems that advisory.cves now contains two CVSS evaluations: NVD and SUSE. Previously, it was only available from SUSE.
Therefore, in this PR, when converting from SUSE OVAL to Vuls model, only CVSS evaluation by SUSE will be adopted. (If SUSE OVAL only has NVD, CveContent will be created, but CVSS evaluation will not be adopted. Evaluation by NVD is imported by go-cve-dictionary in vuls.)
Fixes vulsio/goval-dictionary#384
Type of change
How Has This Been Tested?
add tests.
Checklist:
You don't have to satisfy all of the following.
make fmtmake testIs this ready for review?: YES
Reference