Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use aws-sdk-go-v2 #1922

Merged
merged 1 commit into from
May 24, 2024
Merged

chore(deps): use aws-sdk-go-v2 #1922

merged 1 commit into from
May 24, 2024

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented May 17, 2024

What did you implement:

https://aws.github.io/aws-sdk-go-v2/docs/migrating/

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

vuls report -to-s3

envvar

$ AWS_ACCESS_KEY_ID=<AWS_ACCESS_KEY_ID> AWS_SECRET_ACCESS_KEY=<AWS_SECRET_ACCESS_KEY> vuls report -to-s3

credential files

$ cat ~/.aws/credentials

$ vuls report -to-s3

EC2 IMDS

$ curl 169.254.169.254/latest/meta-data/instance-id/

$ vuls report -to-s3

vuls saas

$ vuls saas

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this May 17, 2024
@MaineK00n MaineK00n linked an issue May 21, 2024 that may be closed by this pull request
@MaineK00n MaineK00n force-pushed the MaineK00n/aws-sdk-go-v2 branch 10 times, most recently from af24af3 to fa4c559 Compare May 22, 2024 13:28
@MaineK00n MaineK00n marked this pull request as ready for review May 22, 2024 13:37
@MaineK00n MaineK00n requested a review from shino May 22, 2024 13:38
}
s, err := session.NewSession(config)
cfg, err := awsConfig.LoadDefaultConfig(context.TODO(), optFns...)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reporter/s3.go Outdated Show resolved Hide resolved
reporter/s3.go Show resolved Hide resolved
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@MaineK00n MaineK00n merged commit d8bce94 into master May 24, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/aws-sdk-go-v2 branch May 24, 2024 10:08
@shino
Copy link
Collaborator

shino commented May 28, 2024

Behavior changed slightly.

When "profile" is specified in config.toml and "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY" are specified in environment variables,

Before: "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY" are used
After: "profile" in config.toml is used

For someone who is running vuls in such configurations, please watch out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants