Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content-Type header to report/mail.go . #280

Merged
merged 1 commit into from Dec 15, 2016
Merged

Add Content-Type header to report/mail.go . #280

merged 1 commit into from Dec 15, 2016

Conversation

hogehuga
Copy link
Contributor

Vuls report mail has NO charset header.
This pull request contain 'Content-Type: text/plain; charset=utf8' header.

@hogehuga hogehuga mentioned this pull request Dec 14, 2016
(fix pull request, "utf8" to "utf-8".)

I did the following test.
- compile vuls with this fix.
- I executed the following command and confirmed that garbled display is not done.
  + vuls scan -lang=en -report-mail -cve-dictionary...
  + vuls scan -lang=ja -report-mail -cve-dictionary...

Mail header is as follows.
Message-Id: <...>
Subject: <...>
Content-Type: text/plain; charset=utf8
From: <...>
To: <...>
Cc: <...>
@hogehuga
Copy link
Contributor Author

Checked RFC and changed utf8 to utf-8.

I tested it as follows.

  • Apply a patch and compile.
  • Execute with the following option.
    • -report-mail lang=en
    • -report-mail lang=ja
  • Confirm that it can display without problems at mail software
    • i checked mutt-1.5.21, sylpheed3.5.1

@kotakanbe kotakanbe merged commit 7b2e2cb into future-architect:master Dec 15, 2016
@kotakanbe
Copy link
Member

Many thanks!

@hogehuga hogehuga deleted the add-mail-header branch December 15, 2016 02:05
@kotakanbe kotakanbe added the bug label Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants