Add -format-one-email option #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
force-pushed
the
add_one-email
branch
5 times, most recently
from
9ea8152
to
d9e5a6d
Compare
knqyf263
force-pushed
the
add_one-email
branch
from
d9e5a6d
to
9fec518
Compare
kotakanbe
reviewed
Feb 15, 2017
report/email.go
Outdated
| conf.EMail.To, | ||
| []byte(message), | ||
| if conf.FormatOneEMail { | ||
| subject := fmt.Sprintf("%s %s", |
There was a problem hiding this comment.
How do you think it would be better to display a summary at the top of the mail?
message = fmt.Sprintf(
`
One Line Summary
================
%s
%s`,
toOneLineSummary(rs...), message)
There was a problem hiding this comment.
One Line Summary
================
cent6 Total: 87 (High:21 Medium:57 Low:5 ?:4) 85 updatable packages
u16 Total: 111 (High:20 Medium:60 Low:7 ?:24) 106 updatable packages
There was a problem hiding this comment.
I got it. Good idea!
I'll fix.
knqyf263
force-pushed
the
add_one-email
branch
from
9fec518
to
f6e5303
Compare
knqyf263
force-pushed
the
add_one-email
branch
from
f6e5303
to
5bd9f4a
Compare
|
Many Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally closed...
I'm sorry to send PR again.
#310