Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(suse): add testcase for detectSUSE #675

Merged
merged 4 commits into from Jun 25, 2018
Merged

refactor(suse): add testcase for detectSUSE #675

merged 4 commits into from Jun 25, 2018

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Jun 25, 2018 •
edited

What did you implement:

#672

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

Jennings Liu and others added 4 commits June 20, 2018 13:39
add SLES_SAP fix
7bdfc3f
add SLES_SAP version regexp
6d4d541
@kotakanbe
refactor(suse): add testcase for detectSUSE
1d7f7b9
@kotakanbe
Merge branch 'master' into 672
075cfab 
* master:
  pull request to add SLES variant OS SLES_SAP support (#672)
  feat(syslog): add all CVSS scores/vectors (#664)
@kotakanbe kotakanbe merged commit 9e9370b into master Jun 25, 2018
kotakanbe added a commit that referenced this pull request Jun 28, 2018
@kotakanbe
Merge branch 'master' into v0.5.0
d27183f 
* master:
  refactor(suse): add testcase for detectSUSE (#675)
  pull request to add SLES variant OS SLES_SAP support (#672)
@kotakanbe kotakanbe deleted the 672 branch July 24, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kotakanbe