Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix double checking ResultsDir Path #927

Merged
merged 1 commit into from Dec 12, 2019

Conversation

s-index
Copy link
Contributor

@s-index s-index commented Dec 9, 2019

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

Vuls scan checks ResultsDir Path twice.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I execute vuls scan at latest version(v0.9.1 d6e74cc).

$ vuls -v
vuls v0.9.1 build-20191209_233537_d6e74cc
$ vuls scan -results-dir=vuls
[Dec  9 22:40:35]  INFO [localhost] Start scanning
[Dec  9 22:40:35]  INFO [localhost] config: /Users/vuls/config.toml
[Dec  9 22:40:35]  INFO [localhost] Validating config...
ERRO[0000] JSON base directory must be a *Absolute* file path. -results-dir: vuls 
ERRO[0000] JSON base directory must be a *Absolute* file path. -results-dir: vuls
$

I execute vuls scan at fixed version(2cdb7bf).

$ vuls -v
vuls v0.9.1 build-20191209_234102_2cdb7bf
$ vuls scan -results-dir=vuls
[Dec  9 23:09:37]  INFO [localhost] Start scanning
[Dec  9 23:09:37]  INFO [localhost] config: /Users/vuls/config.toml
[Dec  9 23:09:37]  INFO [localhost] Validating config...
ERRO[0000] JSON base directory must be a *Absolute* file path. -results-dir: vuls 
$ 

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes

Reference

@kotakanbe kotakanbe merged commit c17b415 into future-architect:master Dec 12, 2019
@kotakanbe
Copy link
Member

@s-index
Many thanks :)

@s-index s-index deleted the fix-ValidateOnScan branch December 12, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants