stdio/rtt: Don't silently drop println statements #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still silently truncates prints, but during printf debugging, those are still understood more easily than skipped lines.
|
So this makes the output always blocking? would that stall applications when there's no debugger attached? |
ah no, that would be Somehow I was under the impression that probe-rs actually switches to blocking mode if it is attached, but I can't find a reference anymore. anyhow, trimming is better than fully skipping. so, lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still silently truncates prints, but during printf debugging, those are still understood more easily than skipped lines.
We're probably migrating to something more defmt anyway, but this fixes a repeated issue I've been running into when I thought my code is in weird branches just because the printf("Stage 1 {:?}", ...) silently didn't do anything at all.
(At some point we'll probably have similar high-level stdio discussions as in riot-c regarding whether to block and what to do in ISRs, but this is just a small step here and shouldn't touch the controversial topics).