Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

SwiftLint integration #9

Merged
merged 15 commits into from
Jan 14, 2019
Merged

SwiftLint integration #9

merged 15 commits into from
Jan 14, 2019

Conversation

RomanPodymov
Copy link
Contributor

@RomanPodymov RomanPodymov commented Jan 5, 2019

Hello.
As I promised here I integrated Swiftlint to this project. Also I set language to Swift 4.2 and fixed some warnings.
Please update your bitrise settings to Swift 4.2/Xcode 10.1.

@RomanPodymov RomanPodymov mentioned this pull request Jan 5, 2019
@mkj-is mkj-is requested a review from a team January 7, 2019 07:43
@mkj-is
Copy link
Contributor

mkj-is commented Jan 8, 2019

Bitrise settings were updated and the build was successful.

Example/LocationManager/AppDelegate.swift Outdated Show resolved Hide resolved
Pod/Classes/LocationObserver.swift Outdated Show resolved Hide resolved
@mkj-is mkj-is changed the title Swiftlint integration SwiftLint integration Jan 8, 2019
Copy link
Contributor

@mkj-is mkj-is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkj-is mkj-is merged commit 06819e6 into futuredapp:master Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants