Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Java interoperability - remove lambdas from public interface #21

Merged
merged 3 commits into from
Feb 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ package com.thefuntasty.hauler.databinding

import androidx.databinding.BindingAdapter
import com.thefuntasty.hauler.HaulerView
import com.thefuntasty.hauler.OnDragDismissedListener
import com.thefuntasty.hauler.setOnDragDismissedListener

@BindingAdapter("app:onDragDismissedListener")
fun HaulerView.setOnDragDismissedListener(listener: OnDragDismissedListener) {
this.setOnDragDismissedListener { listener.onDragDismissed(it) }
this.setOnDragDismissedListener { listener.onDismissed(it) }
}
8 changes: 4 additions & 4 deletions library/src/main/kotlin/com/thefuntasty/hauler/HaulerView.kt
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class HaulerView @JvmOverloads constructor(
private var draggingUp = false
private var mLastActionEvent: Int = 0

private var onDragDismissed: ((dragDirection: DragDirection) -> Unit) = { }
private var onDragDismissedListener: OnDragDismissedListener? = null
private var systemChromeFader: SystemChromeFader? = null

private var isDragEnabled = true
Expand Down Expand Up @@ -141,8 +141,8 @@ class HaulerView @JvmOverloads constructor(
* Set lambda reference which is called when dismiss gesture has
* been performed
*/
fun setOnDragDismissedListener(onDragDismissedListener: (dragDirection: DragDirection) -> Unit) {
onDragDismissed = onDragDismissedListener
fun setOnDragDismissedListener(onDragDismissedListener: OnDragDismissedListener) {
this.onDragDismissedListener = onDragDismissedListener
}

/**
Expand Down Expand Up @@ -211,6 +211,6 @@ class HaulerView @JvmOverloads constructor(

private fun dispatchDismissCallback(dragDirection: DragDirection) {
systemChromeFader?.onDismiss()
onDragDismissed.invoke(dragDirection)
onDragDismissedListener?.onDismissed(dragDirection)
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.thefuntasty.hauler

fun HaulerView.setOnDragDismissedListener(onDragDismissedListener: (DragDirection) -> Unit) {
this.setOnDragDismissedListener(object : OnDragDismissedListener {
override fun onDismissed(dragDirection: DragDirection) {
onDragDismissedListener.invoke(dragDirection)
}
})
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package com.thefuntasty.hauler

interface OnDragDismissedListener {
fun onDismissed(dragDirection: DragDirection)
}
10 changes: 7 additions & 3 deletions sample/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,19 @@

<activity
android:name=".draggable.SimpleActivity"
android:theme="@style/AppTheme.Draggable"/>
android:theme="@style/AppTheme.Draggable" />

<activity
android:name=".draggable.advanced.AdvancedActivity"
android:theme="@style/AppTheme.Draggable"/>
android:theme="@style/AppTheme.Draggable" />

<activity
android:name=".draggable.databinding.DatabindingActivity"
android:theme="@style/AppTheme.Draggable"/>
android:theme="@style/AppTheme.Draggable" />

<activity
android:name=".draggable.SimpleJavaActivity"
android:theme="@style/AppTheme.Draggable" />

</application>
</manifest>
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.thefuntasty.haulersample
import android.os.Bundle
import androidx.appcompat.app.AppCompatActivity
import com.thefuntasty.haulersample.draggable.SimpleActivity
import com.thefuntasty.haulersample.draggable.SimpleJavaActivity
import com.thefuntasty.haulersample.draggable.advanced.AdvancedActivity
import com.thefuntasty.haulersample.draggable.databinding.DatabindingActivity
import kotlinx.android.synthetic.main.activity_main.*
Expand All @@ -24,5 +25,9 @@ class MainActivity : AppCompatActivity() {
startBindingButton.setOnClickListener {
startActivity(DatabindingActivity.getStartIntent(this))
}

startJavaCommonButton.setOnClickListener {
startActivity(SimpleJavaActivity.getStartIntent(this))
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.content.Context
import android.content.Intent
import android.os.Bundle
import androidx.appcompat.app.AppCompatActivity
import com.thefuntasty.hauler.setOnDragDismissedListener
import com.thefuntasty.haulersample.R
import kotlinx.android.synthetic.main.activity_simple.*

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package com.thefuntasty.haulersample.draggable;

import android.app.Activity;
import android.content.Context;
import android.content.Intent;
import android.os.Bundle;

import androidx.annotation.Nullable;

import com.thefuntasty.hauler.DragDirection;
import com.thefuntasty.hauler.HaulerView;
import com.thefuntasty.hauler.OnDragDismissedListener;
import com.thefuntasty.haulersample.R;

import org.jetbrains.annotations.NotNull;

public class SimpleJavaActivity extends Activity {

public static Intent getStartIntent(Context context) {
return new Intent(context, SimpleJavaActivity.class);
}

@Override
protected void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_simple);

HaulerView hv = findViewById(R.id.commonHaulerView);
hv.setOnDragDismissedListener(new OnDragDismissedListener() {
@Override
public void onDismissed(@NotNull DragDirection dragDirection) {
finish();
}
});
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.os.Bundle
import android.widget.Toast
import androidx.appcompat.app.AppCompatActivity
import com.thefuntasty.hauler.DragDirection
import com.thefuntasty.hauler.setOnDragDismissedListener
import com.thefuntasty.haulersample.R
import kotlinx.android.synthetic.main.activity_advanced.*

Expand Down
13 changes: 10 additions & 3 deletions sample/src/main/res/layout/activity_main.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,28 @@
android:id="@+id/startCommonButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/start_common"
android:text="@string/start_simple"
android:layout_gravity="center"/>

<Button
android:id="@+id/startAdvancedButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/start_advanced"
android:layout_gravity="center"/>
android:layout_gravity="center" />

<Button
android:id="@+id/startBindingButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/start_binding"
android:layout_gravity="center"/>
android:layout_gravity="center" />

<Button
android:id="@+id/startJavaCommonButton"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/start_simple_java"
android:layout_gravity="center" />

</LinearLayout>
3 changes: 2 additions & 1 deletion sample/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<resources>
<string name="app_name">Hauler</string>
<string name="start_common">Start Simple Activity</string>
<string name="start_simple">Start Simple Activity</string>
<string name="start_simple_java">Start Simple Java Activity</string>
<string name="start_advanced">Start Advanced Activity</string>
<string name="start_binding">Start Binding Activity</string>
<string name="swipe_to_dismiss">Swipe down to dismiss</string>
Expand Down