This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
forked from collectiveidea/delayed_job
/
shared_spec.rb
601 lines (498 loc) · 19.5 KB
/
shared_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
require File.expand_path('../../../../spec/sample_jobs', __FILE__)
require 'active_support/core_ext'
shared_examples_for 'a delayed_job backend' do
let(:worker) { Delayed::Worker.new }
def create_job(opts = {})
described_class.create(opts.merge(:payload_object => SimpleJob.new))
end
before do
Delayed::Worker.max_priority = nil
Delayed::Worker.min_priority = nil
Delayed::Worker.default_priority = 99
Delayed::Worker.delay_jobs = true
SimpleJob.runs = 0
described_class.delete_all
end
it "should set run_at automatically if not set" do
described_class.create(:payload_object => ErrorJob.new ).run_at.should_not be_nil
end
it "should not set run_at automatically if already set" do
later = described_class.db_time_now + 5.minutes
job = described_class.create(:payload_object => ErrorJob.new, :run_at => later)
job.run_at.should be_within(1).of(later)
end
describe "#reload" do
it 'should cause the payload to be reloaded' do
job = described_class.enqueue :payload_object => SimpleJob.new
job.payload_object.object_id.should_not == job.reload.payload_object.object_id
end
end
describe "enqueue" do
context "with a hash" do
it "should raise ArgumentError when handler doesn't respond_to :perform" do
lambda { described_class.enqueue(:payload_object => Object.new) }.should raise_error(ArgumentError)
end
it "should be able to set priority" do
job = described_class.enqueue :payload_object => SimpleJob.new, :priority => 5
job.priority.should == 5
end
it "should use default priority" do
job = described_class.enqueue :payload_object => SimpleJob.new
job.priority.should == 99
end
it "should be able to set run_at" do
later = described_class.db_time_now + 5.minutes
job = described_class.enqueue :payload_object => SimpleJob.new, :run_at => later
job.run_at.should be_within(1).of(later)
end
it "should be able to set queue" do
job = described_class.enqueue :payload_object => SimpleJob.new, :queue => 'tracking'
job.queue.should == 'tracking'
end
end
context "with multiple arguments" do
it "should raise ArgumentError when handler doesn't respond_to :perform" do
lambda { described_class.enqueue(Object.new) }.should raise_error(ArgumentError)
end
it "should increase count after enqueuing items" do
described_class.enqueue SimpleJob.new
described_class.count.should == 1
end
it "should be able to set priority [DEPRECATED]" do
silence_warnings do
job = described_class.enqueue SimpleJob.new, 5
job.priority.should == 5
end
end
it "should use default priority when it is not set" do
@job = described_class.enqueue SimpleJob.new
@job.priority.should == 99
end
it "should be able to set run_at [DEPRECATED]" do
silence_warnings do
later = described_class.db_time_now + 5.minutes
@job = described_class.enqueue SimpleJob.new, 5, later
@job.run_at.should be_within(1).of(later)
end
end
it "should work with jobs in modules" do
M::ModuleJob.runs = 0
job = described_class.enqueue M::ModuleJob.new
lambda { job.invoke_job }.should change { M::ModuleJob.runs }.from(0).to(1)
end
end
context "with delay_jobs = false" do
before(:each) do
Delayed::Worker.delay_jobs = false
end
it "should not increase count after enqueuing items" do
described_class.enqueue SimpleJob.new
described_class.count.should == 0
end
it 'should invoke the enqueued job' do
job = SimpleJob.new
job.should_receive(:perform)
described_class.enqueue job
end
it 'should return a job, not the result of invocation' do
described_class.enqueue(SimpleJob.new).should be_instance_of(described_class)
end
end
end
describe "callbacks" do
before(:each) do
CallbackJob.messages = []
end
%w(before success after).each do |callback|
it "should call #{callback} with job" do
job = described_class.enqueue(CallbackJob.new)
job.payload_object.should_receive(callback).with(job)
job.invoke_job
end
end
it "should call before and after callbacks" do
job = described_class.enqueue(CallbackJob.new)
CallbackJob.messages.should == ["enqueue"]
job.invoke_job
CallbackJob.messages.should == ["enqueue", "before", "perform", "success", "after"]
end
it "should call the after callback with an error" do
job = described_class.enqueue(CallbackJob.new)
job.payload_object.should_receive(:perform).and_raise(RuntimeError.new("fail"))
lambda { job.invoke_job }.should raise_error
CallbackJob.messages.should == ["enqueue", "before", "error: RuntimeError", "after"]
end
it "should call error when before raises an error" do
job = described_class.enqueue(CallbackJob.new)
job.payload_object.should_receive(:before).and_raise(RuntimeError.new("fail"))
lambda { job.invoke_job }.should raise_error(RuntimeError)
CallbackJob.messages.should == ["enqueue", "error: RuntimeError", "after"]
end
end
describe "payload_object" do
it "should raise a DeserializationError when the job class is totally unknown" do
job = described_class.new :handler => "--- !ruby/object:JobThatDoesNotExist {}"
lambda { job.payload_object }.should raise_error(Delayed::DeserializationError)
end
it "should raise a DeserializationError when the job struct is totally unknown" do
job = described_class.new :handler => "--- !ruby/struct:StructThatDoesNotExist {}"
lambda { job.payload_object }.should raise_error(Delayed::DeserializationError)
end
it "should raise a DeserializationError when the YAML.load raises argument error" do
job = described_class.new :handler => "--- !ruby/struct:GoingToRaiseArgError {}"
YAML.should_receive(:load).and_raise(ArgumentError)
lambda { job.payload_object }.should raise_error(Delayed::DeserializationError)
end
it "should raise a DeserializationError when the YAML.load raises an unexpected error" do
job = described_class.new :handler => "--- !ruby/struct:GoingToRaiseArgError {}"
YAML.should_receive(:load).and_raise(Exception)
lambda { job.payload_object }.should raise_error(Delayed::DeserializationError)
end
end
describe "reserve" do
before do
Delayed::Worker.max_run_time = 2.minutes
end
it "should not reserve failed jobs" do
create_job :attempts => 50, :failed_at => described_class.db_time_now
described_class.reserve(worker).should be_nil
end
it "should not reserve jobs scheduled for the future" do
create_job :run_at => described_class.db_time_now + 1.minute
described_class.reserve(worker).should be_nil
end
it "should reserve jobs scheduled for the past" do
job = create_job :run_at => described_class.db_time_now - 1.minute
described_class.reserve(worker).should == job
end
it "should reserve jobs scheduled for the past when time zones are involved" do
Time.zone = 'US/Eastern'
job = create_job :run_at => described_class.db_time_now - 1.minute
described_class.reserve(worker).should == job
end
it "should not reserve jobs locked by other workers" do
job = create_job
other_worker = Delayed::Worker.new
other_worker.name = 'other_worker'
described_class.reserve(other_worker).should == job
described_class.reserve(worker).should be_nil
end
it "should reserve open jobs" do
job = create_job
described_class.reserve(worker).should == job
end
it "should reserve expired jobs" do
job = create_job(:locked_by => 'some other worker', :locked_at => described_class.db_time_now - Delayed::Worker.max_run_time - 1.minute)
described_class.reserve(worker).should == job
end
it "should reserve own jobs" do
job = create_job(:locked_by => worker.name, :locked_at => (described_class.db_time_now - 1.minutes))
described_class.reserve(worker).should == job
end
end
context "#name" do
it "should be the class name of the job that was enqueued" do
described_class.create(:payload_object => ErrorJob.new ).name.should == 'ErrorJob'
end
it "should be the method that will be called if its a performable method object" do
job = described_class.new(:payload_object => NamedJob.new)
job.name.should == 'named_job'
end
it "should be the instance method that will be called if its a performable method object" do
job = Story.create(:text => "...").delay.save
job.name.should == 'Story#save'
end
it "should parse from handler on deserialization error" do
job = Story.create(:text => "...").delay.text
job.payload_object.object.destroy
job.reload.name.should == 'Delayed::PerformableMethod'
end
end
context "worker prioritization" do
before(:each) do
Delayed::Worker.max_priority = nil
Delayed::Worker.min_priority = nil
end
it "should fetch jobs ordered by priority" do
10.times { described_class.enqueue SimpleJob.new, :priority => rand(10) }
jobs = []
10.times { jobs << described_class.reserve(worker) }
jobs.size.should == 10
jobs.each_cons(2) do |a, b|
a.priority.should <= b.priority
end
end
it "should only find jobs greater than or equal to min priority" do
min = 5
Delayed::Worker.min_priority = min
10.times {|i| described_class.enqueue SimpleJob.new, :priority => i }
5.times { described_class.reserve(worker).priority.should >= min }
end
it "should only find jobs less than or equal to max priority" do
max = 5
Delayed::Worker.max_priority = max
10.times {|i| described_class.enqueue SimpleJob.new, :priority => i }
5.times { described_class.reserve(worker).priority.should <= max }
end
end
context "worker read-ahead" do
before do
@read_ahead = Delayed::Worker.read_ahead
end
after do
Delayed::Worker.read_ahead = @read_ahead
end
it "should read five jobs" do
described_class.should_receive(:find_available).with(anything, 5, anything).and_return([])
described_class.reserve(worker)
end
it "should read a configurable number of jobs" do
Delayed::Worker.read_ahead = 15
described_class.should_receive(:find_available).with(anything, Delayed::Worker.read_ahead, anything).and_return([])
described_class.reserve(worker)
end
end
context "clear_locks!" do
before do
@job = create_job(:locked_by => 'worker1', :locked_at => described_class.db_time_now)
end
it "should clear locks for the given worker" do
described_class.clear_locks!('worker1')
described_class.reserve(worker).should == @job
end
it "should not clear locks for other workers" do
described_class.clear_locks!('different_worker')
described_class.reserve(worker).should_not == @job
end
end
context "unlock" do
before do
@job = create_job(:locked_by => 'worker', :locked_at => described_class.db_time_now)
end
it "should clear locks" do
@job.unlock
@job.locked_by.should be_nil
@job.locked_at.should be_nil
end
end
context "large handler" do
before do
text = "Lorem ipsum dolor sit amet. " * 1000
@job = described_class.enqueue Delayed::PerformableMethod.new(text, :length, {})
end
it "should have an id" do
@job.id.should_not be_nil
end
end
context "named queues" do
context "when worker has one queue set" do
before(:each) do
worker.queues = ['large']
end
it "should only work off jobs which are from its queue" do
SimpleJob.runs.should == 0
create_job(:queue => "large")
create_job(:queue => "small")
worker.work_off
SimpleJob.runs.should == 1
end
end
context "when worker has two queue set" do
before(:each) do
worker.queues = ['large', 'small']
end
it "should only work off jobs which are from its queue" do
SimpleJob.runs.should == 0
create_job(:queue => "large")
create_job(:queue => "small")
create_job(:queue => "medium")
create_job
worker.work_off
SimpleJob.runs.should == 2
end
end
context "when worker does not have queue set" do
before(:each) do
worker.queues = []
end
it "should work off all jobs" do
SimpleJob.runs.should == 0
create_job(:queue => "one")
create_job(:queue => "two")
create_job
worker.work_off
SimpleJob.runs.should == 3
end
end
end
context "max_attempts" do
before(:each) do
@job = described_class.enqueue SimpleJob.new
end
it 'should not be defined' do
@job.max_attempts.should be_nil
end
it 'should use the max_retries value on the payload when defined' do
@job.payload_object.stub!(:max_attempts).and_return(99)
@job.max_attempts.should == 99
end
end
describe "yaml serialization" do
it "should reload changed attributes" do
story = Story.create(:text => 'hello')
job = story.delay.tell
story.update_attributes :text => 'goodbye'
job.reload.payload_object.object.text.should == 'goodbye'
end
it "should raise error ArgumentError the record is not persisted" do
story = Story.new(:text => 'hello')
lambda {
story.delay.tell
}.should raise_error(ArgumentError, "Jobs cannot be created for records before they've been persisted")
end
it "should raise deserialization error for destroyed records" do
story = Story.create(:text => 'hello')
job = story.delay.tell
story.destroy
lambda {
job.reload.payload_object
}.should raise_error(Delayed::DeserializationError)
end
end
describe "worker integration" do
before do
Delayed::Job.delete_all
SimpleJob.runs = 0
end
describe "running a job" do
it "should fail after Worker.max_run_time" do
begin
old_max_run_time = Delayed::Worker.max_run_time
Delayed::Worker.max_run_time = 1.second
job = Delayed::Job.create :payload_object => LongRunningJob.new
worker.run(job)
job.reload.last_error.should =~ /expired/
job.attempts.should == 1
ensure
Delayed::Worker.max_run_time = old_max_run_time
end
end
context "when the job raises a deserialization error" do
it "should mark the job as failed" do
Delayed::Worker.destroy_failed_jobs = false
job = described_class.create! :handler => "--- !ruby/object:JobThatDoesNotExist {}"
worker.work_off
job.reload
job.should be_failed
end
end
end
describe "failed jobs" do
before do
# reset defaults
Delayed::Worker.destroy_failed_jobs = true
Delayed::Worker.max_attempts = 25
@job = Delayed::Job.enqueue(ErrorJob.new)
end
it "should record last_error when destroy_failed_jobs = false, max_attempts = 1" do
Delayed::Worker.destroy_failed_jobs = false
Delayed::Worker.max_attempts = 1
worker.run(@job)
@job.reload
@job.last_error.should =~ /did not work/
@job.attempts.should == 1
@job.should be_failed
end
it "should re-schedule jobs after failing" do
worker.work_off
@job.reload
@job.last_error.should =~ /did not work/
@job.last_error.should =~ /sample_jobs.rb:\d+:in `perform'/
@job.attempts.should == 1
@job.run_at.should > Delayed::Job.db_time_now - 10.minutes
@job.run_at.should < Delayed::Job.db_time_now + 10.minutes
@job.locked_by.should be_nil
@job.locked_at.should be_nil
end
it 'should re-schedule with handler provided time if present' do
job = Delayed::Job.enqueue(CustomRescheduleJob.new(99.minutes))
worker.run(job)
job.reload
(Delayed::Job.db_time_now + 99.minutes - job.run_at).abs.should < 1
end
it "should not fail when the triggered error doesn't have a message" do
error_with_nil_message = StandardError.new
error_with_nil_message.stub!(:message).and_return nil
@job.stub!(:invoke_job).and_raise error_with_nil_message
lambda{worker.run(@job)}.should_not raise_error
end
end
context "reschedule" do
before do
@job = Delayed::Job.create :payload_object => SimpleJob.new
end
share_examples_for "any failure more than Worker.max_attempts times" do
context "when the job's payload has a #failure hook" do
before do
@job = Delayed::Job.create :payload_object => OnPermanentFailureJob.new
@job.payload_object.should respond_to :failure
end
it "should run that hook" do
@job.payload_object.should_receive :failure
worker.reschedule(@job)
end
end
context "when the job's payload has no #failure hook" do
# It's a little tricky to test this in a straightforward way,
# because putting a should_not_receive expectation on
# @job.payload_object.failure makes that object
# incorrectly return true to
# payload_object.respond_to? :failure, which is what
# reschedule uses to decide whether to call failure.
# So instead, we just make sure that the payload_object as it
# already stands doesn't respond_to? failure, then
# shove it through the iterated reschedule loop and make sure we
# don't get a NoMethodError (caused by calling that nonexistent
# failure method).
before do
@job.payload_object.should_not respond_to(:failure)
end
it "should not try to run that hook" do
lambda do
Delayed::Worker.max_attempts.times { worker.reschedule(@job) }
end.should_not raise_exception(NoMethodError)
end
end
end
context "and we want to destroy jobs" do
before do
Delayed::Worker.destroy_failed_jobs = true
end
it_should_behave_like "any failure more than Worker.max_attempts times"
it "should be destroyed if it failed more than Worker.max_attempts times" do
@job.should_receive(:destroy)
Delayed::Worker.max_attempts.times { worker.reschedule(@job) }
end
it "should not be destroyed if failed fewer than Worker.max_attempts times" do
@job.should_not_receive(:destroy)
(Delayed::Worker.max_attempts - 1).times { worker.reschedule(@job) }
end
end
context "and we don't want to destroy jobs" do
before do
Delayed::Worker.destroy_failed_jobs = false
end
it_should_behave_like "any failure more than Worker.max_attempts times"
it "should be failed if it failed more than Worker.max_attempts times" do
@job.reload.should_not be_failed
Delayed::Worker.max_attempts.times { worker.reschedule(@job) }
@job.reload.should be_failed
end
it "should not be failed if it failed fewer than Worker.max_attempts times" do
(Delayed::Worker.max_attempts - 1).times { worker.reschedule(@job) }
@job.reload.should_not be_failed
end
end
end
end
end