New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC-compatible version #101

Closed
daviddelmonte opened this Issue Nov 15, 2011 · 14 comments

Comments

Projects
None yet
3 participants
@daviddelmonte
Copy link

daviddelmonte commented Nov 15, 2011

Is there any chance of an ARC version of IASK?

Should I give it a shot?

David

ps. My first post on Github :)

@futuretap

This comment has been minimized.

Copy link
Owner

futuretap commented Nov 15, 2011

sure, go ahead, we appreciate any contributions! We won't do it ourselves anytime soon because of backwards compatibility requirements. Would be awesome though if you could #ifdef the changes so that the developer can choose the ARC or non-ARC variant.

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 15, 2011

Will give it a shot.

David

On Nov 15, 2011, at 8:44 AM, FutureTap wrote:

sure, go ahead, we appreciate any contributions! We won't do it ourselves anytime soon because of backwards compatibility requirements. Would be awesome though if you could #ifdef the changes so that the developer can choose the ARC or non-ARC variant.


Reply to this email directly or view it on GitHub:
#101 (comment)

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 15, 2011

As I get started on this, which version should I use. I like the Date and Time elements that were added in September, but they are not part of the main app (I think)..

Thanks

On Nov 15, 2011, at 8:44 AM, FutureTap wrote:

sure, go ahead, we appreciate any contributions! We won't do it ourselves anytime soon because of backwards compatibility requirements. Would be awesome though if you could #ifdef the changes so that the developer can choose the ARC or non-ARC variant.


Reply to this email directly or view it on GitHub:
#101 (comment)

@futuretap

This comment has been minimized.

Copy link
Owner

futuretap commented Nov 15, 2011

We'd prefer the main branch. We might pull some changes but haven't had the time to review them, yet.

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 15, 2011

okeydoke.

On Nov 15, 2011, at 9:53 AM, FutureTap wrote:

We'd prefer the main branch. We might pull some changes but haven't had the time to review them, yet.


Reply to this email directly or view it on GitHub:
#101 (comment)

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 15, 2011

Hi, it's done with some caveats:

  1. There are two warning messages that I do not know how to handle.
  2. I have not yet built in #ifdef yet** as

a) I want to solve 1 above,
b) I'd like you to make sure the new version works,
c) I seem to remember that when you turn on ARC, a compiler setting gets changed, so that you cannot have two versions. I will look into that.

Where should I put this work, so you can check it out?

David

**I have merely commented out the old code so if we can continue after resolving the issues above, I will go back through and make it "multi-generational".

On Nov 15, 2011, at 9:53 AM, FutureTap wrote:

We'd prefer the main branch. We might pull some changes but haven't had the time to review them, yet.


Reply to this email directly or view it on GitHub:
#101 (comment)

@futuretap

This comment has been minimized.

Copy link
Owner

futuretap commented Nov 15, 2011

Best create your own fork and push to that fork. Not sure when I'll be able to look into it, though. But the benefit of GitHub is that there are some others watching here ;)

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 15, 2011

will do.. I've never done this before. Fun..

On Nov 15, 2011, at 11:13 AM, FutureTap wrote:

Best create your own fork and push to that fork. Not sure when I'll be able to look into it, though. But the benefit of GitHub is that there are some others watching here ;)


Reply to this email directly or view it on GitHub:
#101 (comment)

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 15, 2011

Can I just ask if you can see my fork? I'm a noob. I did commit my changes to my account, but I dont see them reflected/referred to in the master.. I dont want to tread on your work...

Thanks

David

On Nov 15, 2011, at 11:13 AM, FutureTap wrote:

Best create your own fork and push to that fork. Not sure when I'll be able to look into it, though. But the benefit of GitHub is that there are some others watching here ;)


Reply to this email directly or view it on GitHub:
#101 (comment)

@futuretap

This comment has been minimized.

Copy link
Owner

futuretap commented Nov 15, 2011

No, you probably haven't yet pushed to Github. Commit and push are always two steps in git.

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 15, 2011

hmm.. I got this..

On Nov 15, 2011, at 12:33 PM, FutureTap wrote:

No, you probably haven't yet pushed to Github. Commit and push are always two steps in git.


Reply to this email directly or view it on GitHub:
#101 (comment)

@tibr

This comment has been minimized.

Copy link

tibr commented Nov 16, 2011

I forked and made an iOS 5 ARC Version, not sure if a pull request would be a good idea at the moment though.
It would be possible to change it to support iOS 4 but you would lose zeroing weak references which takes away a lot of the benefit of ARC...

@daviddelmonte

This comment has been minimized.

Copy link
Author

daviddelmonte commented Nov 16, 2011

Ah, thanks Tim. I agree this is iOS5 only. I also made an ARC version. I will see how my noob skills match up with your version. ( I ran out of time before posting back to Github).

On Nov 16, 2011, at 9:30 AM, Tim Brückmann wrote:

I forked and made a iOS 5 ARC Version, not sure if a pull request would be a good idea at the moment though.
It would be possible to change it to support iOS 4 but you would loose zeroing weak references which takes away a lot of the benefit of ARC...


Reply to this email directly or view it on GitHub:
#101 (comment)

@futuretap

This comment has been minimized.

Copy link
Owner

futuretap commented Nov 24, 2014

IASK is ARCified since quite some time.

@futuretap futuretap closed this Nov 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment