Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/7.52.0 #838

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Release/7.52.0 #838

merged 11 commits into from
Apr 29, 2024

Conversation

surangap
Copy link
Contributor

@surangap surangap commented Apr 24, 2024

Release

Release Name: 7.52.0

Spec Version: 52

Client Version: 7.0.0

Key Changes:

This release includes Ethy gadget Witness message pruning based on the finalized block number.

What can be expected with this change

  • Redundant network gossip activity should be significantly reduced.
  • Should provide fixes for the current peer drop issue.
  • All the existing gossip Witness messages would be discarded due to the new format
  • There is a chance of discarding witnesses before they can form the proof if goes out of the live window. But under normal conditions this should not happen. A separate mechanism to handle these scenarios will be introduced later.

Note - at post deployment, need to make sure at least 66% of the active validators are upgraded to the new image. otherwise could halt the proof formation due to not being able to reach consensus.

PRs included:


Client Changes:

  • Yes
  • No

Runtime Changes:

  • Yes
  • No

Storage Changes:

Changed:

Extrinsic Changes:

Added:

Changed:

Event Changes:

Added:

Error Messages:

Added:

Storage Migrations:

Added:

Removed:

Implementation details

  • Add block_number to Witness
  • Active validators now include finalized block number(that the proof request was made) in the Witness message
  • Define WINDOW_SIZE = 90 or the live window, proof needs to be generated within this window. approximately ~6mins.
  • Update GossipValidator to include a reference to Backend
  • Any incoming Witness gossip messages that are outside the live window would be discarded.
  • change REBROADCAST_AFTER to 3 mins, allowing a second rebroadcast within the live window
  • Increase MAX_COMPLETE_EVENT_CACHE to 500

@surangap surangap merged commit 4d9f6e1 into main Apr 29, 2024
7 checks passed
@surangap surangap deleted the release/7.52.0 branch April 29, 2024 00:16
This was referenced Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants