Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation on the use of support library #25

Closed
kaushikgopal opened this issue Nov 6, 2014 · 7 comments
Closed

Recommendation on the use of support library #25

kaushikgopal opened this issue Nov 6, 2014 · 7 comments

Comments

@kaushikgopal
Copy link

  • Should one use the support library?
  • When does it make sense to use the support library?
  • What are the advantages of using support fragments vs normal fragments (a.k.a android.app.Fragment vs android.support.v4.app.Fragment)?

The answer(s) to the above question might make a lot of sense in an android best practices doc?

@recuutus
Copy link
Contributor

recuutus commented Nov 6, 2014

In my opinion:

  • Yes
  • From the start of the project
  • I would recommend using the support library whenever possible. One argument for it is that SL can be updated much more often than Android framework itself if a bug is found. Also the newest API's can get backported to older Android version thanks to the SL.

@staltz
Copy link
Contributor

staltz commented Nov 7, 2014

👍 @recuutus could you send a PR with these advices added into the "libraries" section?

@jaggernod
Copy link

OK, will do that when I have some time

@staltz
Copy link
Contributor

staltz commented Nov 7, 2014

Sure

@kaushikgopal
Copy link
Author

it's worth listing the disadvantages for support library use too:

  1. android.support.v4.app.Fragments do custom animations very differently (they use tween animations instead of object animators which make animations far more easy to deal with).
  2. support libraries obviously bump up your apk size.
  3. choosing "which" support library is always a mind bending penance-involved decision.
    etc.

(most of these are not deal breaking for a majority of use cases.

@jaggernod
Copy link

Created a pull request: #29

@ilkka
Copy link

ilkka commented Jan 17, 2015

Closed as #29 has been merged.

@ilkka ilkka closed this as completed Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants