Add Timber logging #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-tackage
added
pr::in progress
pr::awaiting review
and removed
pr::in progress
labels
|
Should resolve #1 |
| /** | ||
| * Exception reporting mechanism. | ||
| * | ||
| * Implmentations should simply delegate to the Exception reporting mechanism of choice. |
There was a problem hiding this comment.
There is a typo in the word Implementations
|
It looks good but I haven't tested it. |
|
Release build is currently broken. Blocked until that is resolved. |
peter-tackage
force-pushed
the
feature/add-timber-logging
branch
from
d0a0ed2
to
dddd989
Compare
|
Need to retest on release build |
peter-tackage
force-pushed
the
feature/add-timber-logging
branch
from
dddd989
to
14f31ee
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timber provides a simple way to redirect logging. It also has the benefit of removing an Android dependency from your logging code; no need to import
android.util.Login application code.