Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in urllib usage #2

Closed
midicase opened this issue Feb 13, 2023 · 2 comments
Closed

typo in urllib usage #2

midicase opened this issue Feb 13, 2023 · 2 comments

Comments

@midicase
Copy link

https://github.com/futzu/new_reader/blob/main/new_reader.py#L82
return urllib.requesturlopen(req) -> return urllib.request.urlopen(req)

@futzu
Copy link
Owner

futzu commented Feb 13, 2023

Thanks man, I appreciate it. I'll fix it right now.

futzu added a commit that referenced this issue Feb 13, 2023
@futzu
Copy link
Owner

futzu commented Feb 13, 2023

Fixed.

a@debian:~/new_reader$ pypy3
Python 3.9.16 (7.3.11+dfsg-2, Feb 06 2023, 16:52:03)
[PyPy 7.3.11 with GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>> from new_reader import reader
>>>> with reader("https://iodisco.com/bb/index.m3u8",headers={"hey":"I am a hea\
der"}) as rdr:
....     print(
....     rdr.read())
....     
b'#EXTM3U\n#EXT-X-VERSION:3\n#EXT-X-TARGETDURATION:3\n#EXT-X-MEDIA-SEQUENCE:4157709\n#EXT-X-DISCONTINUITY-SEQUENCE:4499\n#EXT-X-X9K3-VERSION:0.1.63\n#EXTINF:2.000,\nseg4157709.ts\n#EXTINF:2.000,\nseg4157710.ts\n#EXTINF:2.033,\nseg4157711.ts\n#EXTINF:2.000,\nseg4157712.ts\n#EXTINF:2.000,\nseg4157713.ts\n'

image

This is my favorite, I use new_reader in everything.
Thanks again man, I appreciate the heads up.

@futzu futzu closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants