Fix fields method to follow airtable spec #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding `fields[21]` (more than 21 fields), airtable API throws an error such as:
```json
{
"error": {
"type": "INVALID_REQUEST_UNKNOWN",
"message": "Invalid request: parameter validation failed. Check your request data."
}
}
```
Don't ask me why this breaks airtable, but according to the airtable api docs, the list of fields params should only include the brackets, not a number. Here's an example from their docs:
"
For example, to only return data from Event Name and Performers, send these two query parameters:
fields%5B%5D=Fieldname1&fields%5B%5D=Fieldname2
Note: %5B%5D may be omitted when specifying multiple fields, but must always be included when specifying only a single field.
"
Submitting the requests without the numeric indexes in the fields[] works fine with 21 or more fields in the list.
…testcase. Also added a fix for a Java 8 compiler issue due to method ambiguity. IDE inspections may complain that there is an unnecessary cast (JsonNode) but at least Java 8 will be able to compile the file now. See here for discussion regarding the issue and the fix: https://stackoverflow.com/questions/32294140/java-8-reference-to-method-is-ambiguous
minorgod
referenced
this pull request
in JellyfishSDK/whale
Apr 12, 2022
fuxingloh
approved these changes
Apr 13, 2022
|
Hey, thanks for merging that! I was temporarily using Jitpack to substitute my fork and my team was complaining about it. I was worried you might not still be maintaining this lib. Glad to see you still are! Hope you can figure out how to publish to Maven so I can remove Jitpack from my build config before someone on my team rages on me. :) |
|
Hey thanks, it's published https://repo1.maven.org/maven2/dev/fuxing/airtable-api/0.3.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding
fields[21](more than 21 fields), airtable API throws an error such as:{ "error": { "type": "INVALID_REQUEST_UNKNOWN", "message": "Invalid request: parameter validation failed. Check your request data." } }Don't ask me why this breaks airtable, but according to the airtable api docs, the list of fields params should only include the brackets, not a number. Here's an example from their docs:
Submitting the requests without the numeric indexes in the fields[] works fine with 21 or more fields in the list.