Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shows: add ability to retrieve trending shows #23

Merged
merged 1 commit into from
Jun 24, 2015
Merged

shows: add ability to retrieve trending shows #23

merged 1 commit into from
Jun 24, 2015

Conversation

LalitMaganti
Copy link
Contributor

  • currently this is incomplete - it just returns the show and does
    not return the number of watchers which the API does

* currently this is incomplete - it just returns the show and does
  not return the number of watchers which the API does
@LalitMaganti
Copy link
Contributor Author

Hey! I wasn't really sure how to handle the watchers int so I thought I'd go with the minimal modification approach and just add the ability to retrieve the shows themselves and get your opinion on it before going any further.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.18%) to 84.37% when pulling 4f07bd8 on tilal6991:develop into 472bb02 on fuzeman:develop.

@LalitMaganti
Copy link
Contributor Author

Ping @fuzeman

@fuzeman fuzeman merged commit 4f07bd8 into fuzeman:develop Jun 24, 2015
fuzeman added a commit that referenced this pull request Jun 24, 2015
Conflicts:
	trakt/mapper/summary.py
fuzeman added a commit that referenced this pull request Jun 24, 2015
…`trending()` method to the `MoviesInterface`
fuzeman added a commit that referenced this pull request Jun 24, 2015
@fuzeman
Copy link
Owner

fuzeman commented Jun 24, 2015

Sorry for the late response, just merged this PR into the develop branch and made a few changes to finish it off.


Changes:

  • Added the watchers property to Movie and Show objects
  • Added the trending() method to the movies interface
  • Added tests for the trending() methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants