Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Extract __version__ to safe import module #41

Merged
merged 1 commit into from
Sep 25, 2015

Conversation

shad7
Copy link
Contributor

@shad7 shad7 commented Sep 24, 2015

The trakt/__init__.py references many modules including 3rd party
modules which might not be installed already. The import within the
setup.py results in an ImportError.

fixes #40

Review on Reviewable

The `trakt/__init__.py` references many modules including 3rd party
modules which might not be installed already. The import within the
setup.py results in an ImportError.

fixes fuzeman#40
fuzeman added a commit that referenced this pull request Sep 24, 2015
fuzeman added a commit that referenced this pull request Sep 25, 2015
@fuzeman
Copy link
Owner

fuzeman commented Sep 25, 2015

This will still import the __init__.py file, leading to the ImportError again:

Traceback (most recent call last):
  File "<string>", line 20, in <module>
  File "/tmp/pip-eCKisP-build/setup.py", line 1, in <module>
    from trakt.version import __version__
  File "trakt/__init__.py", line 3, in <module>
    from trakt.client import TraktClient
  File "trakt/client.py", line 1, in <module>
    from trakt.core.configuration import ConfigurationManager
  File "trakt/core/configuration.py", line 1, in <module>
    from trakt.core.context_collection import ContextCollection
  File "trakt/core/context_collection.py", line 4, in <module>
    from six.moves import _thread as thread
ImportError: No module named six.moves

cd05732 should complete the fix, will release a new version now.

There is some more details on possible solutions on https://packaging.python.org/en/latest/single_source_version/#single-sourcing-the-version

@fuzeman fuzeman merged commit 8046ae8 into fuzeman:master Sep 25, 2015
@shad7 shad7 deleted the bugfix/install branch September 25, 2015 01:27
@shad7
Copy link
Contributor Author

shad7 commented Sep 25, 2015

@fuzeman Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation error
2 participants