Sticky + Preloaded Themes #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LightDestory
commented
Apr 15, 2018
LightDestory
commented
- Added sticky property to navigator
- Removed double navigator, now it is sticky
- Added the possibility to add hard-codded defaults themes
- Added Webtoon theme
Added sticky property to navigator Removed double navigator, now it is sticky Added the possibility to add hard-codded defaults themes Added Webtoon theme
fuzetsu
reviewed
Jun 1, 2018
| @@ -1810,6 +1859,7 @@ var getViewer = function(prevChapter, nextChapter) { | |||
| var settings = '<table><tr><td>'; | |||
| // Custom CSS | |||
| var cssProfiles = storeGet('ml-setting-css-profiles'); | |||
| preloadProfiles(cssProfiles); | |||
There was a problem hiding this comment.
This call needs to be after the following if that creates the default profile or it will crash on a fresh install (since cssProfiles will be undefined).
fuzetsu
reviewed
Jun 1, 2018
| @@ -1571,6 +1616,10 @@ var getViewer = function(prevChapter, nextChapter) { | |||
| 'z-index': '100', | |||
| 'position': 'relative' | |||
| }, '.ml-counter'), | |||
| navdivCss = toStyleStr({ | |||
| 'position': 'sticky', | |||
There was a problem hiding this comment.
Not sure how I feel about the sticky nav, it overlaps the image and kind of distracts a bit.
|
Thanks for the contribution, and sorry for the incredibly late review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.