[Playlist] dont use istream directly to a tinyxml structure

Turn istream into a std::string to handle large buffers (xbmc#20305)
fuzzard · Oct 12, 2021 · 80c8138 · 80c8138
1 parent c7ee2d8
commit 80c8138
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/xbmc/playlists/PlayListPLS.cpp b/xbmc/playlists/PlayListPLS.cpp
@@ -289,8 +289,9 @@ bool CPlayListASX::LoadData(std::istream& stream)
   }
   else
   {
+    std::string asxstream(std::istreambuf_iterator<char>(stream), {});
     CXBMCTinyXML xmlDoc;
-    stream >> xmlDoc;
+    xmlDoc.Parse(asxstream, TIXML_DEFAULT_ENCODING);
 
     if (xmlDoc.Error())
     {
@@ -300,6 +301,9 @@ bool CPlayListASX::LoadData(std::istream& stream)
 
     TiXmlElement *pRootElement = xmlDoc.RootElement();
 
+    if (!pRootElement)
+      return false;
+
     // lowercase every element
     TiXmlNode *pNode = pRootElement;
     TiXmlNode *pChild = NULL;