Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #85 and #87: FL_LOG, FL_BUILD_PATH, and examples #116

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

jcrada
Copy link
Member

@jcrada jcrada commented Oct 21, 2022

No description provided.

@jcrada
Copy link
Member Author

jcrada commented Oct 21, 2022

Hi @josch. Do these changes look good to address your requests of #85 and #87? Thanks!

@josch
Copy link
Contributor

josch commented Oct 22, 2022

Hard to say. It doesn't apply to the last release because file locations (of fuzzylite.h) and indentation changed too much. Maybe just release and I'll file follow-up bugs in case something is still amiss?

I have one comment just from reading the code: I do not think finding the leftmost "fuzzylite" is the correct solution. You should find the rightmost "fuzzylite" or otherwise this will not work if fuzzylite is built inside a path that itself contains the string "fuzzylite".

@josch
Copy link
Contributor

josch commented Nov 24, 2022

Hi, just a friendly ping for this pull request. Could you make a new release so that I can test the current development status as a Debian package? Thanks!

@jcrada
Copy link
Member Author

jcrada commented Nov 29, 2022

HI @josch. Thanks! I will focus on this during the December holidays, planning to advance lots. Maybe also undo the file formatting and leave it for last so it has a cleaner git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants