Imporive Pester tests

fvanroie · Oct 6, 2018 · 05b27bd · 05b27bd
1 parent b4e36f2
commit 05b27bd
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 62 deletions.
diff --git a/Tests/Get-OPNsenseItem.Tests.ps1 b/Tests/Get-OPNsenseItem.Tests.ps1
@@ -7,7 +7,7 @@ InModuleScope PS_OPNsense {
 
     $Modules = $OPNsenseOpenApi.Keys | Sort-Object
 
-    Describe "Get-OPNsenseItem" {
+    Describe "Get-OPNsenseItem" -Tags Items {
         foreach ($Module in $modules) {
 
             $testcases = @()

diff --git a/Tests/Get-OPNsenseSetting.Tests.ps1 b/Tests/Get-OPNsenseSetting.Tests.ps1
@@ -14,7 +14,7 @@ InModuleScope PS_OPNsense {
         }
     }
 
-    Describe "Getting All Settings" {
+    Describe "Getting All Settings" -Tags Settings {
         Context "Get-OPNsenseSetting" {
 
             It "<module> <setting> Settings should not throw" -TestCases $testcases {

diff --git a/Tests/Quagga.Tests.ps1 b/Tests/Quagga.Tests.ps1
diff --git a/Tests/_Connect-OPNsense.Tests.ps1 b/Tests/_Connect-OPNsense.Tests.ps1
@@ -19,41 +19,43 @@ Function Test-ObjectType ($obj) {
     return ($obj | Get-Member | Select-Object -ExpandProperty TypeName -First 1)
 }
 
-Describe "Check Help" {
-    Context "Public Cmdlets should have a Get-Help:" {
+Describe "Check Help" -Tags 'Help' {
+    Context "All public Cmdlets should have a Get-Help:" {
         $cmdlets = @()
+
         Get-Command -Module PS_OPNsense | ForEach-Object {
             $cmdlets += @{'name' = $_.name}
         }
-        it "<name> has a Get-Help entry" -TestCases $cmdlets {
+
+        it "<name> has a help entry" -TestCases $cmdlets {
             param ($name)
             if ((Get-Help -Name $name).synopsis -eq '' -Or (Get-Help -Name $name).description -eq $null) {
                 Set-TestInconclusive "$name has no help"
             }
             (Get-Help -Name $name).synopsis -ne '' -And (Get-Help -Name $name).description -ne $null | Should Be $true
         }
+
     }
 }
 
 
 InModuleScope PS_OPNsense {
 
-    Describe "Connect-OPNsense" -Tags Connect {
+    Describe "Connect-OPNsense" -Tags 'Connect' {
         $result = Get-OPNsense
 
-        It "Connection succeeded" {
+        It "Connection should succeed" {
             $result.connection | Should Be 'ok'
         }
+
         It "Check productname" {
             if ($result.product_name -ne 'opnsense-devel') {
                 $result.product_name | Should Be 'opnsense'
             } else {
-                Set-TestInconclusive
+                $result.product_name | Should Be 'opnsense-devel'
+                #Set-TestInconclusive
             }
         }
-        It 'Has a Get-Help entry' {
-            (Get-Help -Name Get-OPNsense).synopsis | Should Not Be ''
-        }
 
     }
 }