Fix PSScriptAnalyzer warnings

fvanroie · Jun 13, 2018 · b4d9571 · b4d9571
1 parent 6cc9090
commit b4d9571
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Private/Get-Constructor.ps1 b/Private/Get-Constructor.ps1
@@ -84,7 +84,7 @@ Function Get-Constructor {
     )
     Process {
         If ($PSBoundParameters['AsObject']) {
-            $type.GetConstructors() | ForEach {
+            $type.GetConstructors() | ForEach-Object {
                 $object = New-Object PSobject -Property @{
                     Type       = $_.DeclaringType
                     Parameters = $_.GetParameters()
@@ -95,9 +95,9 @@ Function Get-Constructor {
 
 
         } Else {
-            $Type.GetConstructors() | Select @{
+            $Type.GetConstructors() | Select-Object @{
                 Label      = "$($type.Name) Constructors"
-                Expression = {($_.GetParameters() | ForEach {$_.ToString()}) -Join ", "}
+                Expression = {($_.GetParameters() | ForEach-Object {$_.ToString()}) -Join ", "}
             }
         }
     }

diff --git a/Public/Settings/Get-OPNsenseSetting.ps1 b/Public/Settings/Get-OPNsenseSetting.ps1
@@ -50,7 +50,7 @@ Function Get-OPNsenseSetting {
 
         # Get the Invoke Arguments List
         $arglist = $OPNsenseSettingMap.settings.$Module.$Setting.$Command.command
-        $returntype = $OPNsenseSettingMap.settings.$Module.$Setting.$Command.returntype
+        #$returntype = $OPNsenseSettingMap.settings.$Module.$Setting.$Command.returntype
 
         # Build Invoke Arguments Splat
         $splat = @{};