Update Pester Tests

fvanroie · Oct 4, 2018 · c9d6671 · c9d6671
1 parent c4071b7
commit c9d6671
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/Core/_Connect-OPNsense.Tests.ps1 b/Core/_Connect-OPNsense.Tests.ps1
@@ -38,7 +38,7 @@ Describe "Check Help" {
 
 InModuleScope PS_OPNsense {
 
-    Describe "Connect-OPNsense" {
+    Describe "Connect-OPNsense" -Tags Connect {
         $result = Get-OPNsense
 
         It "Connection succeeded" {

diff --git a/Public/Items/Get-OPNsenseItem.Tests.ps1 b/Public/Items/Get-OPNsenseItem.Tests.ps1
@@ -9,25 +9,30 @@ InModuleScope PS_OPNsense {
 
     Describe "Get-OPNsenseItem" {
         foreach ($Module in $modules) {
-
-            $testcases = foreach ($action in $OPNsenseOpenApi.$Module.keys) {
+
+            $testcases = @()
+
+            foreach ($action in $OPNsenseOpenApi.$Module.keys) {
                 foreach ($object in $OPNsenseOpenApi.$Module.$Action.keys) {
                     # CRUD items implement search action
                     if ($action -eq 'search') {
                         $testcase = @{ 'Module' = $module; 'Item' = $object}
                         Write-Output $testcase
+                        $testcases += $testcase
                     }
-                }        
+                }    
             }
 
+            if ($testcases.count -eq 0) { Continue }
+
             Context "Module $Module" {
 
                 It "Get <module> <item>" -TestCases $testcases {
                     param($module, $item)
                     if ($module -eq 'relayd') {
-                        Set-TestInconclusive "$Module is under development"
+                        #Set-TestInconclusive "$Module is under development"
                     }
-                    $Splat = @{ "$Module" = "$Item"}
+                    $Splat = @{ 'Module' = $module; 'Item' = $item}
                     {
                         $result = Get-OPNsenseItem @Splat
                     }  | should Not Throw

diff --git a/Public/Items/New-OPNsenseItem.Tests.ps1 b/Public/Items/New-OPNsenseItem.Tests.ps1
@@ -7,7 +7,7 @@ InModuleScope PS_OPNsense {
 
     $Modules = $OPNsenseOpenApi.Keys | Sort-Object
 
-    Describe "New-OPNsenseItem" {
+    Describe "New-OPNsenseItem" -Tags Items {
         foreach ($Module in $modules) {
 
             $testcases = foreach ($action in $OPNsenseOpenApi.$Module.keys) {
@@ -28,6 +28,10 @@ InModuleScope PS_OPNsense {
                         Set-TestInconclusive "$Module is under development"
                     }
                     $Splat = @{ "$Module" = "$Item"}
+                    $Splat = @{
+                        "Module" = $Module
+                        "Item"   = $Item
+                    }
                     #{
                     #    $result = Get-OPNsenseItem @Splat
                     #}  | should Not Throw

diff --git a/Public/Settings/Get-OPNsenseSetting.Tests.ps1 b/Public/Settings/Get-OPNsenseSetting.Tests.ps1
@@ -20,7 +20,7 @@ InModuleScope PS_OPNsense {
             It "<module> <setting> Settings should not throw" -TestCases $testcases {
                 param($module, $setting)
                 if ($module -eq 'Relayd') {
-                    Set-TestInconclusive "$Module is under development"
+                    #Set-TestInconclusive "$Module is under development"
                 } 
                 {
                     $result = Get-OPNsenseSetting -Module $module -Setting $setting