Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return statement prevents callback from HTTP error triggering #11

Closed
jshbrntt opened this issue Sep 27, 2017 · 2 comments
Closed

Return statement prevents callback from HTTP error triggering #11

jshbrntt opened this issue Sep 27, 2017 · 2 comments
Labels
bug

Comments

@jshbrntt
Copy link

jshbrntt commented Sep 27, 2017 •
edited

This return statement is preventing the callback being called, causing it to hang indefinitely.

I'm getting a 301 error by the way.

https://github.com/fvdm/nodejs-requestbin/blob/develop/requestbin.js#L46-L47
@jshbrntt jshbrntt changed the title Return statement prevents callb Return statement prevents callback from HTTP error triggering Sep 27, 2017
@fvdm
Copy link
Owner

fvdm commented Sep 27, 2017

Yikes, that’s a ugly mistake!
Working on it right away

fvdm added a commit that referenced this issue Sep 27, 2017
@fvdm
Fix(response): Rewrite error response (#11)
b51a986
fvdm added a commit that referenced this issue Sep 27, 2017
@fvdm
Fix(doError): Fixed missing options (#11)
65516ab
fvdm added a commit that referenced this issue Sep 27, 2017
@fvdm
Fix(talk): Changed base url to HTTPS (#11)
f076fff 
The 301 error is a redirect to the new HTTPS url
@fvdm
Copy link
Owner

fvdm commented Sep 27, 2017

@synthecypher Fixed both issues and released v1.5.1 on npm.

Thanks for reporting.

@fvdm fvdm closed this as completed Sep 27, 2017
@fvdm fvdm added the bug label Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fvdm @jshbrntt