Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix possible error from iTunes response #30

Closed
wants to merge 1 commit into from
Closed

fix possible error from iTunes response #30

wants to merge 1 commit into from

Conversation

fabioricali
Copy link

this adds a try/catch for possible no JSON response

@fabioricali
fix possible error from iTunes response
eed3dd4 
this adds a try/catch for possible no JSON response
fvdm added a commit that referenced this pull request Dec 29, 2021
@fvdm
Refactor: Cleaner async functions #30
6739a5f
fvdm added a commit that referenced this pull request Dec 29, 2021
@fvdm
Refactor async functions #30 (#31)
7b5b111 
* Refactor: Cleaner async functions #30

* Fix: Await keysInObject() check

* Fix: Exports function declaration
@fvdm
Copy link
Owner

fvdm commented Dec 29, 2021

Hi @fabioricali, I noticed the whole code needed a better promises implementation, so instead I went for a small rewrite.

Thanks for the submit!

@fvdm fvdm closed this Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabioricali @fvdm