Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Conditions are not properly calculated during skill or gear rolls #83

Closed
r-valyar opened this issue Nov 16, 2023 · 2 comments
Closed

[BUG] Conditions are not properly calculated during skill or gear rolls #83

r-valyar opened this issue Nov 16, 2023 · 2 comments
Assignees
@Cussa

Comments

@r-valyar
Copy link

During combat and skill checks involved gears, we noticed that mental conditions are taken into account to rolls that are physical.

We also noticed that physical conditions are not taken into account at all. We had to compensate with bonus dice each time.

image

image
@Cussa
Copy link
Collaborator

Cussa commented Nov 16, 2023 •
edited

Can you share a screenshot of the rifle item? I want to confirm that everything is configured correctly.

@Cussa Cussa self-assigned this Nov 16, 2023
@Cussa
Copy link
Collaborator

Cussa commented Nov 17, 2023

@r-valyar thanks for reporting that. It seems that the weapon roll was calculating it wrong.
However, it seems that the skill rolls, attribute rolls, fear rolls are using the correct conditions. Can you confirm if that's the case?
I will check here to prepare a version 3.3.1 with the fix

DrOgres added a commit that referenced this issue Nov 17, 2023
@DrOgres
Merge pull request #85 from Cussa/master
b22e4f8 
fix #83: weapon roll not calculating conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cussa Cussa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cussa @r-valyar