Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes (weapon icon, vagabond start equipement, talent selection on roll dialog, player sheet with a cut, chargen issue when re-roll, remove rolls from limited player sheet) #105

Merged
merged 7 commits into from
Jan 24, 2024
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ This system provides character sheets and items for your play, if you would lik
## Release Notes
=======

v4.3.1
- 🐛 Fix: get weapon icon when dragging to macro bar
- 🐛 Fix: Vagabond start equipment should be "Quarterstaff" (fix #104)
- 🐛 Fix: removes "None" from Talent selection
- 💄🐛 UI/Fix: corrects the player character sheet cut on the bottom
- 🐛 Fix: Chargen issue when re-roll character
- 🐛 Fix: remove click/roll functionality from the limited character sheet

v4.3.0
- Improvement: any roll using the `/r` chat command now shows the result of the roll directly
![D66 Roll](asset/d66roll.png?raw=true)
Expand Down
3 changes: 3 additions & 0 deletions script/actor/vaesen-actor-sheet.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ export class VaesenActorSheet extends ActorSheet {

activateListeners(html) {
super.activateListeners(html);
if (this.actor.limited)
return;

html.find(".item-create").click((ev) => {
this.onItemCreate(ev);
});
Expand Down
5 changes: 4 additions & 1 deletion script/sheet/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ export class PlayerCharacterSheet extends VaesenActorSheet {
activateListeners(html) {
super.activateListeners(html);

if (this.actor.limited)
return;

html.find(".fav-togle").click((ev) => {
this.onFavTogle(ev);
});
Expand Down Expand Up @@ -227,7 +230,7 @@ export class PlayerCharacterSheet extends VaesenActorSheet {
const div = $(item).parents(".weapon");
const itemId = div.data("itemId");
const itemName = $(item).text();
const img = $(div).children(".icon").attr("src");
const img = $(div).find(".icon").attr("src");
const testName = `${itemName} ${game.i18n.localize("ROLL.ROLL")}`;

const data = {
Expand Down
2 changes: 1 addition & 1 deletion script/util/generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export class generator {
label: game.i18n.localize("GENERATOR.REROLL"),
callback: async () => {
reroll = true;
await generator.generateCharacter();
await generator.generateCharacter(actor);
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion script/util/generator_data.js
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ export class generator_data {
"Well-traveled"
],
equipment: [
"Walking stick",
"Quarterstaff",
"Knife or Dagger",
"Crowbar",
"Liquor",
Expand Down
1 change: 0 additions & 1 deletion script/util/roll.js
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ function buildSelectMultipleHtmlDialog(options, name, id) {
);
html.push(`<div class="flex row" style="width: 100%;">`);
html.push(`<select id="${id}" style="width: 100%;" multiple>`);
html.push(`<option value="0">None (0)</option>`);
options.forEach((element) => {
let descriptionWithoutTags = $("<p>").html(element.description).text();
let requiresBonus =
Expand Down
2 changes: 1 addition & 1 deletion style/player.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.vaesen .player {
height: 100%;
/* height: 100%; */
width: 100%;
}

Expand Down
2 changes: 1 addition & 1 deletion system.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"title": "Vaesen",
"description": "Nordic horror role-playing",
"version": "4.3.0",
"version": "4.3.1",
"esmodules": [
"script/hooks.js"
],
Expand Down