Merge df9bcf2 into 06cbe73

fwal · Nov 5, 2017 · c19924d · c19924d
2 parents 06cbe73 + df9bcf2
commit c19924d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -11,3 +11,4 @@ rvm:
 
 script:
     - bundle exec rake spec
+    - bundle exec danger --verbose
diff --git a/Dangerfile b/Dangerfile
@@ -0,0 +1,2 @@
+
+favro.check(key: "BAS")
diff --git a/Gemfile b/Gemfile
@@ -2,3 +2,7 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in danger-favro.gemspec
 gemspec
+
+gem "danger"
+
+# Should also find BAS-17
diff --git a/lib/favro/api_client.rb b/lib/favro/api_client.rb
@@ -22,8 +22,6 @@ def get(ticket_ids)
     def request(ticket_id)
       response = RestClient::Request.execute method: :get, url: "https://favro.com/api/v1/cards?cardSequentialId=#{ticket_id}&unique=true&limit=1", headers: { accept: :json, organizationId: @organization_id }, user: @user_name, password: @api_token
       JSON.parse(response)
-    rescue RestClient::ExceptionWithResponse
-      nil
     end
   end
 end