Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat: #39 support cwd anv env variables (using org.eclipse.jdt.debug package) #43

Conversation

thunderz99
Copy link
Contributor

An enhance for #39

Done

  • cwd
    • Add "cwd" for LaunchConfiguration
      • default to ${projectRoot} if null or blank
    • Add a custom KDALaunchingConnector which extends SocketLaunchingConnectorImpl and implements "cwd"
    • Add a Eclipse Public License header to KDALaunchingConnector.kt file which is modified based on org.eclipse.jdi.internal.connect.SocketLaunchingConnectorImpl
    • Add unit test for cwd
  • env variables
    • Add "envs" for LaunchConfiguration
    • Add unit test for envs
  • support for jdk1.8

Doing

  • Support for jdk11
  • A better solution for org.eclipse.jdt.debug dependencies
    implementation files('lib/org.eclipse.jdt.debug-3.15.100.jdi.jar')
    implementation files('lib/org.eclipse.jdt.debug-3.15.100.jdimodel.jar')

@thunderz99 thunderz99 marked this pull request as draft July 1, 2020 10:18
@fwcd
Copy link
Owner

fwcd commented Jul 1, 2020

Sorry for being pedantic, but I think it would be ideal if we wrote the entire implementation ourselves. EPL ist still not as permissive as MIT.

Inheriting the Sun launcher is fine (it wouldn't introduce a new dependency) as long as we write the overridden methods completely ourselves and possibly call super where needed.

@thunderz99
Copy link
Contributor Author

I think your advice is indeed and acceptable. I'll have a try :)
I'll open a new pullreq when it is ready!

@thunderz99 thunderz99 closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants