Pick Kotlin stdlib based on compiled Kotlin version #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar25h
commented
Oct 1, 2022
omar25h
commented
- Ignore path when comparing versions
- Pick the local Kotlin stdlib version based on the compiled version. This prevents potential issues in case there are multiple Kotlin versions used on the same machine.
- Ignore path when comparing versions - Pick the local Kotlin stdlib version based on the compiled version. This prevents potential issues in case there are multiple Kotlin versions used on the same machine.
omar25h
force-pushed
the
omar25h/enhance-stdlib-detection
branch
from
abca91b
to
46f0db4
Compare
fwcd
reviewed
Oct 3, 2022
| @@ -116,6 +106,6 @@ private fun compareVersions(left: Path, right: Path): Int { | |||
| return -leftVersion.size.compareTo(rightVersion.size) | |||
| } | |||
| private fun extractVersion(artifactVersionDir: Path): List<String> { | |||
| return artifactVersionDir.toString().split(".") | |||
| return artifactVersionDir.toString().split("/").last().split(".") | |||
There was a problem hiding this comment.
Suggested change
| return artifactVersionDir.toString().split("/").last().split(".") | |
| return artifactVersionDir.fileName.toString().split(".") |
| } | ||
| else -> name.startsWith(artifact) && name.endsWith(".jar") | ||
| } | ||
| name == "$artifact-${KotlinVersion.CURRENT}.jar" |
There was a problem hiding this comment.
This uses the language server's version of Kotlin, right? This might go wrong if the user has a different version of Kotlin installed than what the language server uses.
There was a problem hiding this comment.
Good point. However, I think we need a better way to figure out the Kotlin version in the project on which the LSP runs, maybe via extracting the version from the Gradle configuration, if possible.
The current implementation uses the first version it finds, which also doesn't necessarily match the Kotlin version used in the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.