Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BinaryExpression a structure #16

Closed
fwcd opened this issue Feb 17, 2023 · 0 comments
Closed

Make BinaryExpression a structure #16

fwcd opened this issue Feb 17, 2023 · 0 comments
Labels
enhancement New feature or request model Model-related

Comments

@fwcd
Copy link
Owner

fwcd commented Feb 17, 2023

https://github.com/fwcd/mini-slice/blob/9b8b862b21b976583f1e25909d392b23d046e421/MiniSlice.swiftpm/Sources/Model/Recipe/BinaryExpression.swift#L3

This would probably entail

  • using the @Box property wrapper for lhs and rhs
  • integrating BinaryOperator into the Pretty hierarchy
    • Perhaps even remove its CustomStringConvertible conformance? This would require updating the tokenizer accordingly.
  • updating the tests, the interpreter and other places
@fwcd fwcd added enhancement New feature or request model Model-related labels Feb 17, 2023
@fwcd fwcd pinned this issue Feb 17, 2023
@fwcd fwcd mentioned this issue Feb 17, 2023
Open
@fwcd fwcd closed this as completed in b0c0b6a Feb 18, 2023
@fwcd fwcd unpinned this issue Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request model Model-related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fwcd