Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to override JAVA_OPTS directly in the extension #121

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

themkat
Copy link
Contributor

@themkat themkat commented Mar 24, 2023

If you run Visual Studio Code from a shell, this might seem redundant. If it is run directly from a GUI on the other hand, it might be difficult for some users to be able to set their JAVA_OPTS and have VSCode pick it up. One example is OS X where many environment variables are not sent if run through Spotlight. (yeah, I know it is possible to tweak, but let's make it more user friendly than that!). This PR aims to make it super easy for people to be able to configure their Java options by need. One big example is to combat issues like #120 and fwcd/kotlin-language-server#441 with a custom heap size setting:

image

It might also help users who want to tweak other settings easily like the garbage collector being used. Computers with beefy CPUs might have owners who want to use the parallel garbage collector to limit heap size at the cost of CPU usage with -XX:+UseParallelGC.

@themkat
Copy link
Contributor Author

themkat commented Mar 28, 2023

@fwcd , any thoughts here? Based upon the recent activity in the language server issues and in this repo, it seems like there are several people who might get some use from something like this 🙂

@fwcd
Copy link
Owner

fwcd commented Jun 12, 2023

Thanks!

@fwcd fwcd merged commit 480bad1 into fwcd:main Jun 12, 2023
@themkat themkat deleted the java_opts_settings branch June 14, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants