Incorporate the fix for mclogit issue 24 (melff/mclogit#24).

fweber144 · Apr 20, 2022 · 4351a8d · 4351a8d
1 parent cf9a745
commit 4351a8d
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/tests/testthat/test_proj_predfun.R b/tests/testthat/test_proj_predfun.R
@@ -666,11 +666,11 @@ test_that(paste(
     }))
   if ((packageVersion("mclogit") <= "0.8.7.3" ||
        packageVersion("mclogit") >= "0.9.4.1") &&
-      FALSE) { # TODO: Replace `FALSE` by `packageVersion("mclogit") > "0.9.4.1"` (or similar) as soon as fixed in mclogit.
+      packageVersion("mclogit") >= "0.9.4.2") {
     # Not run for mclogit versions between 0.8.7.3 and 0.9.4.1 because of
     # mclogit's GitHub issue #23.
-    # Currently not run (for mclogit versions <= 0.9.4.1) because of mclogit's
-    # GitHub issue #24.
+    # Not run for mclogit versions < 0.9.4.2 because of mclogit's GitHub issue
+    # #24.
     expect_equal(unname(lpreds_orig_dummy), unname(lpreds_orig_dummy_man),
                  tolerance = 1e-14)
   }
@@ -739,11 +739,11 @@ test_that(paste(
     }))
   if ((packageVersion("mclogit") <= "0.8.7.3" ||
        packageVersion("mclogit") >= "0.9.4.1") &&
-      FALSE) { # TODO: Replace `FALSE` by `packageVersion("mclogit") > "0.9.4.1"` (or similar) as soon as fixed in mclogit.
+      packageVersion("mclogit") >= "0.9.4.2") {
     # Not run for mclogit versions between 0.8.7.3 and 0.9.4.1 because of
     # mclogit's GitHub issue #23.
-    # Currently not run (for mclogit versions <= 0.9.4.1) because of mclogit's
-    # GitHub issue #24.
+    # Not run for mclogit versions < 0.9.4.2 because of mclogit's GitHub issue
+    # #24.
     expect_equal(unname(lpreds_orig), unname(lpreds_orig_man),
                  tolerance = 1e-14)
   }