Error: EACCES: permission denied, scandir

[alexgorbatchev]

Describe the bug

I have a few docker volume mounts in the workspace, preview.js fails to start because it can't traverse into those folders:

500 in endpoint /previews/start:
[Error: EACCES: permission denied, scandir '...'] {
  errno: -13,
  code: 'EACCES',
  syscall: 'scandir',
  path: '...
}

Reproduction

1. chown a folder to another user
2. attempt to review

Preview.js CLI version

not sure where it is, just installed it via VSCode

Framework

react 18

System Info

n/a

Used Package Manager

pnpm

CLI logs (useful for crashes)

No response

Browser logs (useful for rendering errors)

No response

Repo link (if available)

No response

Anything else?

No response

[alexgorbatchev]

Another thing I want to point out, it's trying to scan folders OUTSIDE of the workspace it found:

i have a web folder which is a root folder for the node.js project in my work space, I see:

✨ Created Preview.js workspace for: /home/b/web

EACCES error is for /home/a/folder.

[alexgorbatchev]

and one more thing, the folder it's trying to scan is in .gitignore

[fwouts]

Thanks @alexgorbatchev, will investigate!

[fwouts]

This appears to be a bug in https://github.com/sindresorhus/globby (see https://github.com/fwouts/globby-eaccess-bug for repro), but the good news is I think I know how to fix it. Let's hope they accept my PR once it's ready :)

Edit: PR is now up for review at sindresorhus/globby#246

[alexgorbatchev]

@fwouts excellent find! 👏

[fwouts]

Hey @alexgorbatchev, this should now be fixed in v1.21. Let me know if that works for you!