Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cflags in generate_sbat.py #32

Closed
wants to merge 1 commit into from
Closed

Conversation

gmbr3
Copy link
Contributor

@gmbr3 gmbr3 commented Dec 14, 2022

This fixes a wchar length difference in fwup-sbat.o seen on ARM32

@hughsie hughsie requested a review from superm1 December 14, 2022 18:22
Copy link
Member

@superm1 superm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done by CFLAGS environment variable?

This fixes a wchar length difference in fwup-sbat.o seen on ARM32
@gmbr3
Copy link
Contributor Author

gmbr3 commented Dec 14, 2022

Shouldn't this be done by CFLAGS environment variable?

Yes but that literally isn't used anywhere in this project, I just needed it be in-line with the other files.

Copy link
Member

@superm1 superm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense to sync up compile_args, thanks.

@gmbr3
Copy link
Contributor Author

gmbr3 commented Jan 1, 2023

#33

@gmbr3 gmbr3 closed this Jan 1, 2023
@gmbr3 gmbr3 deleted the generate-sbat-3 branch April 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants