Fix NX Compatibility

[superm1]

It was supposed to be set, but an argument was missing. This sets it and makes sure it's set.

[hughsie]

I don't think we have genpeimg in fedora -- @vathpela -- help?

[superm1]

Ahah, and the arch failure is the reason I wanted to flip the default. I would have had no idea!

@ArchangeGabriel, I think we're missing genpeimg in arch. I looked through https://archlinux.org/packages/ but couldn't find it. Can you help?

We need it to make the default NX compatibility.

[superm1]

I can alternatively come up with a way to do this with python3-pefile if that's more readily available.

[superm1]

So I don't lose it in my history, here is how to do it with python3-pefile:

import pefile
pe = pefile.PE(file)
pe.OPTIONAL_HEADER.DllCharacteristics |= pefile.DLL_CHARACTERISTICS["IMAGE_DLLCHARACTERISTICS_NX_COMPAT"]
pe.write('new.efi')

[superm1]

OK, I think this is maximum flexibility now. Uses genpeimg as a preference and python3-pefile if not present. If both are missing fail the build. Net outcome should be we're always NX compatible.

[hughsie]

Yell when you want a new tarball.

[superm1]

Yell when you want a new tarball.

I think now. Everyone is about to spin shim so we should make them spin this too.

[ArchangeGabriel]

Ahah, and the arch failure is the reason I wanted to flip the default. I would have had no idea!

@ArchangeGabriel, I think we're missing genpeimg in arch. I looked through https://archlinux.org/packages/ but couldn't find it. Can you help?

We need it to make the default NX compatibility.

Where is it supposed to be coming from? (I only see mingw related things by searching that on the net).

Also note that @FFY00 and @freswa are also maintaining fwupd in Arch now (and actually more actively than me!). ;)

[superm1]

Where is it supposed to be coming from? (I only see mingw related things by searching that on the net).

Yeah it comes from a mingw package as I can tell. What we ended up doing instead was making it a dependency for either that or python3-pefile, which I did manage to find in the arch repos. We added it to CI and confirmed it fixes the Arch build.

Also note that @FFY00 and @freswa are also maintaining fwupd in Arch now (and actually more actively than me!). ;)

OK, thanks for heads up! FYI - Once @hughsie tags a build you guys will need to bump your PKGBUILD for fwupd-efi to include python-pefile.

[FFY00]

Yeah, no worries, just ping me here or on IRC when that happens, if possible. If I don't act timely, please ping me again, as ADHD sometimes lets my brain get hijacked by other things 😅