Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress message is not updated properly when a device is waiting for replug #4540

Closed
chlee75 opened this issue Apr 21, 2022 · 3 comments · Fixed by #4541
Closed

Progress message is not updated properly when a device is waiting for replug #4540

chlee75 opened this issue Apr 21, 2022 · 3 comments · Fixed by #4541
Assignees
Labels

Comments

@chlee75
Copy link
Collaborator

chlee75 commented Apr 21, 2022

Describe the bug
Issue 1. Progress bar message (e.g. Less than one minute remaining...) used in the writing process remains in the waiting process in the gnome-firmware or fwupmgr.

image

Issue 2. The progress bar message in the writing process is not consistent.
Sometimes it ends with "Writing..., Less than one minute remaining..."
Sometimes it ends with "Writing..., 17 minutes remaining..."
Sometimes it ends with "Writing..., 1 minute remaining..."

Steps to Reproduce

  1. Connect HP G5 or G4 dock to your computer.
  2. Open gnome-firmware
  3. Start firmware upgrade or reinstall or downgrade
  4. The Progress bar message is changed from "Writing..., Less than one minute remaining..." to "Waiting..., Less than one minute remaining..."
    or
    The progress bar message is changed from "Writing..., 17 minutes remaining..." to "Waiting..., 17 minutes remaining..."

Expected behavior
For Issue 1. The Progress bar message (e.g. Less than one minute remaining...) used in the writing process should not be displayed in the waiting process.

For Issue 2. The Progress bar message in the writing process should be consistent.

fwupd version information
fwupd version is 1.8.0 and gnome-firmware version is 42.1

fwupd device information
plugin is ccgx and device is HP USB-C Dock G5 or HP Thunderbolt Dock G4.

@hughsie
Copy link
Member

hughsie commented Apr 21, 2022

commit 833dcc3f95b4c9ecfafcf5b5375a16cd478a827d
Author: Richard Hughes richard@hughsie.com
Date: Thu Apr 21 14:46:45 2022 +0100

Do not show the estimated time to completion

This is too inaccurate to be useful.

Fixes https://github.com/fwupd/fwupd/issues/4540

:100644 100644 53cb376 5ab5053 M src/gfu-main.c

@hughsie hughsie closed this as completed Apr 21, 2022
@superm1
Copy link
Member

superm1 commented Apr 21, 2022

commit 833dcc3f95b4c9ecfafcf5b5375a16cd478a827d Author: Richard Hughes richard@hughsie.com Date: Thu Apr 21 14:46:45 2022 +0100

Do not show the estimated time to completion

This is too inaccurate to be useful.

Fixes https://github.com/fwupd/fwupd/issues/4540

:100644 100644 53cb376 5ab5053 M src/gfu-main.c

Here's a better link to it https://gitlab.gnome.org/World/gnome-firmware/-/commit/833dcc3f95b4c9ecfafcf5b5375a16cd478a827d

@chlee75
Copy link
Collaborator Author

chlee75 commented Apr 22, 2022

@hughsie

"Less than one minute remaining... " message also remained when I use fwupdmgr command.
Waiting… [***************************** ] Less than one minute remaining...

I think that fwupd seems to be modified.

And Let me know how to test the new gnome-firmware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants