Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupdmgr: "WARNING: UEFI ESP partition may not be set up correctly" for no apparent reason #6035

Closed
vmatare opened this issue Jul 27, 2023 · 26 comments · Fixed by #6507
Closed

Comments

@vmatare
Copy link

vmatare commented Jul 27, 2023

Describe the bug
Whenever I execute fwupdmgr, I get:

WARNING: UEFI ESP partition may not be set up correctly
See https://github.com/fwupd/fwupd/wiki/PluginFlag:esp-not-valid for more information.

The link however is dead (leads to "create new page").

Steps to Reproduce
Don't know what's causing it. That is precisely the problem. fwupdtool esp-list --verbose seems to be working just fine:

10:34:09.115 FuDebug              verbose to info (on console 1)
10:34:09.115 FuEngine             starting fwupd 1.9.3…
Selected volume: /org/freedesktop/UDisks2/block_devices/nvme0n1p1
/boot/efi/EFI/BOOT/BOOTIA32.EFI
/boot/efi/EFI/BOOT/BOOTX64.EFI
/boot/efi/EFI/BOOT/fbia32.efi
/boot/efi/EFI/BOOT/fbx64.efi
/boot/efi/EFI/fedora/fw/fwupd-a28cc671-fabc-4eb1-9a7b-a10a5223c64e.cap
/boot/efi/EFI/fedora/fwupdx64.efi
/boot/efi/EFI/fedora/BOOTIA32.CSV
/boot/efi/EFI/fedora/BOOTX64.CSV
/boot/efi/EFI/fedora/gcdia32.efi
/boot/efi/EFI/fedora/gcdx64.efi
/boot/efi/EFI/fedora/grubia32.efi
/boot/efi/EFI/fedora/grubx64.efi
/boot/efi/EFI/fedora/mmia32.efi
/boot/efi/EFI/fedora/mmx64.efi
/boot/efi/EFI/fedora/shim.efi
/boot/efi/EFI/fedora/grub.cfg.rpmsave
/boot/efi/EFI/fedora/shimia32.efi
/boot/efi/EFI/fedora/grubenv.rpmsave
/boot/efi/EFI/fedora/shimx64.efi
/boot/efi/EFI/fedora/grub.cfg
/boot/efi/System/Library/CoreServices/SystemVersion.plist
/boot/efi/mach_kernel
/boot/efi/System Volume Information/IndexerVolumeGuid
/boot/efi/System Volume Information/WPSettings.dat
/boot/efi/$RECYCLE.BIN/desktop.ini

Expected behavior
I expect some info on why fwupdmgr thinks something is wrong with my ESP.

fwupd version information

fwupdmgr --version
compile   org.freedesktop.fwupd         1.9.3
compile   com.hughsie.libxmlb           0.3.11
compile   com.hughsie.libjcat           0.1.13
runtime   org.freedesktop.fwupd-efi     1.4
compile   org.freedesktop.gusb          0.4.5
runtime   com.hughsie.libjcat           0.1.13
runtime   org.freedesktop.gusb          0.4.5
runtime   org.freedesktop.fwupd         1.9.3
runtime   org.kernel                    6.4.4-200.fc38.x86_64

Please note how you installed it (apt, dnf, pacman, source, etc): dnf

**fwupd device information**

Please provide the output of the fwupd devices recognized in your system.

fwupdmgr get-devices --show-all-devices
WARNING: UEFI ESP partition may not be set up correctly                                                                                                                                            
See https://github.com/fwupd/fwupd/wiki/PluginFlag:esp-not-valid for more information.                                                                                                             
LENOVO 20J7S1BQ00                                                                                                                                                                                  
│                                                                                                                                                                                                  
├─ThinkPad Dock:                                                                                                                                                                                   
│ │   Device ID:          1f914e619b232dc4da68ec3389b98b20163003a2                                                                                                                                 
│ │   Summary:            USB 3.x hub                                                                                                                                                              
│ │   Current version:    50.40                                                                  
│ │   Vendor:             LENOVO (USB:0x17EF)
│ │   Install Duration:   10 seconds                                                             
│ │   GUIDs:              8d708000-7d3b-5e85-ac9d-8ef32fb2d445 ← USB\VID_17EF&PID_1010
│ │                       253815c5-5730-5ece-baea-453f12cefcfb ← USB\VID_17EF&PID_1010&HUB_10                                                                                                      
│ │                       06cdabc6-2059-5daa-87ab-2f6fc31fd74b ← USB\VID_17EF&PID_1010&SPI_C220
│ │                       43abf8a0-7a20-55b6-a405-2a7013c826c0 ← USB\VID_17EF&PID_1010&SPI_C220&REV_5040
│ │   Device Flags:       • Updatable
│ │                       • Cryptographic hash verification is available
│ │                       • Unsigned Payload                                                     
│ │                                       
│ └─Komplete Audio 6:           
│       Device ID:        b513cf41bc1e11e220c56fcec9b93006bb7a1bc1
│       Current version:  0.32               
│       Vendor:           Native Instruments (USB:0x17CC)
│       Serial Number:    19BA6673                                                               
│       GUID:             ae6d4e4b-2fd5-50dc-b5b6-e389facbebbd ← USB\VID_17CC&PID_1001
│       Device Flags:     • Updatable      
│                                    
├─ThinkPad Dock:                                                                                 
│     Device ID:          23d940eac81a886d3523a7d731f2b68a2bedb0f7
│     Summary:            USB 3.x hub                                                            
│     Current version:    50.41                                                                  
│     Vendor:             LENOVO (USB:0x17EF)                                                    
│     Install Duration:   10 seconds
│     GUIDs:              8d708000-7d3b-5e85-ac9d-8ef32fb2d445 ← USB\VID_17EF&PID_1010
│                         1df23e1b-0cb9-52e0-9b9d-f8ed96aac18e ← USB\VID_17EF&PID_1010&HUB_0010
│                         06cdabc6-2059-5daa-87ab-2f6fc31fd74b ← USB\VID_17EF&PID_1010&SPI_C220
│                         b435be36-7b59-5463-ab34-abfe22cf7a53 ← USB\VID_17EF&PID_1010&SPI_C220&REV_5041
│     Device Flags:       • Updatable                                                                                                                                                              
│                         • Cryptographic hash verification is available
│                         • Unsigned Payload
│                                                                                                
├─ADATA SX8000NP:                                                                                
│     Device ID:          310f45f1f223064b5c16bf6dff31146755a64480
│     Summary:            NVM Express solid state drive
│     Current version:    C2.3.7a              
│     Vendor:             Silicon Motion, Inc. (NVME:0x126F)
│     Serial Number:      2I0620037615                                                                                                                                                             
│     GUIDs:              8984b5e5-405c-5a22-93c1-2e88f03889ac ← NVME\VEN_126F&DEV_2260                                                                                                            
│                         12fdc90c-1c70-5c8b-8505-c2a3cd33d581 ← NVME\VEN_126F&DEV_2260&SUBSYS_126F2260                                   
│                         18a60560-7db2-5115-906b-86aae509283a ← ADATA SX8000NP                                                                                                                    
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                                                                                                
├─Core™ i7-7820HQ CPU @ 2.90GHz:                                                                                                                                                                   
│     Device ID:          4bde70ba4e39b28f9eab1628f9dd6e6244c03027                                                                                                                                 
│     Current version:    0x000000f2
│     Vendor:             Intel                                                                  
│     GUIDs:              b9a2dd81-159e-5537-a7db-e7101d164d3f ← cpu
│                         30249f37-d140-5d3e-9319-186b1bd5cac3 ← CPUID\PRO_0&FAM_06
│                         809a0b93-8a12-5338-a571-ad5583acf896 ← CPUID\PRO_0&FAM_06&MOD_9E
│                         d0f754d5-1395-5573-bc83-85ba955da70a ← CPUID\PRO_0&FAM_06&MOD_9E&STP_9
│     Device Flags:       • Internal device                                                      
│                                                                                                
├─Embedded Controller:                                                                           
│     Device ID:          349bb341230b1a86e5effe7dfe4337e1590227bd
│     Summary:            UEFI ESRT device                                                       
│     Current version:    0.1.5                                                                  
│     Minimum Version:    0.0.1                                                                  
│     Vendor:             Lenovo (DMI:LENOVO)                                                    
│     Update State:       Needs reboot
│     Last modified:      2023-07-27 10:30
│     GUID:               a28cc671-fabc-4eb1-9a7b-a10a5223c64e
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─GM108M [GeForce 940MX]:
│     Device ID:          5987c136e0024e0f45943927a31c5c4c711f3eb0
│     Current version:    a2
│     Vendor:             NVIDIA Corporation (PCI:0x10DE, PCI:0x8086)
│     GUIDs:              96c4a8d8-4d13-5ab3-908b-a4aa84fa3617 ← PCI\VEN_10DE&DEV_134D
│                         3473c92a-d781-5d7d-a3be-f4188ced5345 ← PCI\VEN_10DE&DEV_134D&SUBSYS_17AA505E
│                         0dd27e33-7477-5771-a3fe-a5447fa36598 ← PCI\VEN_8086&DEV_1909
│                         688d452a-34bd-5323-a88e-b0146d6e2176 ← PCI\VEN_8086&DEV_1909&SUBSYS_17AA505D
│     Device Flags:       • Internal device
│                         • Cryptographic hash verification is available
│   
├─HD Graphics 630:
│     Device ID:          5792b48846ce271fab11c4a545f7a3df0d36e00a
│     Current version:    04
│     Vendor:             Intel Corporation (PCI:0x8086)
│     GUIDs:              f744dc01-a247-5543-b9db-2adba3091233 ← PCI\VEN_8086&DEV_591B
│                         b4bce577-97f5-5645-a3a2-bc4e47cac6df ← PCI\VEN_8086&DEV_591B&SUBSYS_17AA505E
│     Device Flags:       • Internal device
│                         • Cryptographic hash verification is available
│   
├─System Firmware:
│ │   Device ID:          a45df35ac0e948ee180fe216a5f703f32dda163f
│ │   Summary:            UEFI ESRT device
│ │   Current version:    0.1.40
│ │   Minimum Version:    0.1.15
│ │   Vendor:             Lenovo (DMI:LENOVO)
│ │   Update State:       Success
│ │   GUIDs:              65aa7586-ed3e-49f0-a494-5c43011040f2
│ │                       230c8b18-8d9b-53ec-838b-6cfc0383493a ← main-system-firmware
│ │   Device Flags:       • Internal device
│ │                       • Updatable
│ │                       • System requires external power source
│ │                       • Supported on remote server
│ │                       • Needs a reboot after installation
│ │                       • Cryptographic hash verification is available
│ │                       • Device is usable for the duration of the update
│ │ 
│ ├─UEFI Platform Key:
│ │     Device ID:        6924110cde4fa051bfdc600a60620dc7aa9d3c6a
│ │     Summary:          TPCDL-KEK
│ │     Vendor:           Lenovo(Beijing) Ltd.
│ │     GUID:             6086080e-ea67-57fd-a4e1-75c6681a78ee ← UEFI\CRT_5F3497DD36FB1E78386178DE807D745CBB10B621
│ │   
│ └─UEFI dbx:
│       Device ID:        362301da643102b9f38477387e2193e57abaa590
│       Summary:          UEFI revocation database
│       Current version:  371
│       Minimum Version:  371
│       Vendor:           UEFI:Linux Foundation
│       Install Duration: 1 second
│       GUIDs:            23052f5e-859d-553d-82d9-be3a0bb8074b ← UEFI\CRT_7688DC95F3F8543593BAB00E6EDC00CB2628D27517D71F6C6959F985B38E1C93
│                         f6b25d12-4374-5605-adfe-3092b2d8c551 ← UEFI\CRT_7688DC95F3F8543593BAB00E6EDC00CB2628D27517D71F6C6959F985B38E1C93&ARCH_X64
│                         c6682ade-b5ec-57c4-b687-676351208742 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503
│                         f8ba2887-9411-5c36-9cee-88995bb39731 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503&ARCH_X64
│       Device Flags:     • Internal device
│                         • Updatable
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Only version upgrades are allowed
│                         • Signed Payload
│     
└─TPM:
      Device ID:          c6a80ac3a22083423992a3cb15018989f37834d6
      Current version:    7.61.10.57600
      Vendor:             Infineon (TPM:IFX)
      GUIDs:              ff71992e-52f7-5eea-94ef-883e56e034c6 ← system-tpm
                          5eebb112-75ad-5536-b173-a11eb3399402 ← TPM\VEN_IFX&DEV_0000
                          ddf995da-1b32-5a8a-bc1b-8d5af4b38b51 ← TPM\VEN_IFX&MOD_SLB9670
                          6d81ab63-db2e-50ac-934f-6be9accf5e02 ← TPM\VEN_IFX&DEV_0000&VER_2.0
                          301555de-680d-5ddc-b995-7553fc9138f1 ← TPM\VEN_IFX&MOD_SLB9670&VER_2.0
      Device Flags:       • Internal device
                          • System requires external power source
                          • Needs a reboot after installation
                          • Device can recover flash failures
                          • Full disk encryption secrets may be invalidated when updating
                          • Signed Payload

Additional questions

  • Operating system and version: Fedora 38
  • Have you tried rebooting? sure
  • Is this a regression? don't know
@vmatare vmatare added the bug label Jul 27, 2023
@vmatare vmatare changed the title fwupdmgr: Dead URL in WARNING: UEFI ESP partition may not be set up correctly fwupdmgr: "WARNING: UEFI ESP partition may not be set up correctly" for no apparent reason Jul 27, 2023
@hughsie
Copy link
Member

hughsie commented Jul 27, 2023

Hmm, that page sure used to exist. Perhaps someone deleted it?

@hughsie
Copy link
Member

hughsie commented Jul 27, 2023

I've added a link to https://github.com/fwupd/fwupd/wiki/LVFS-Triaged-Issue:-Invalid-ESP-Partition as that's the one I think should be used to describe this. fwupdtool esp-list --verbose will work fine -- but the firmware might not. Newer machines are much more strict about partitions being tagged with the correct GUID.

@hughsie
Copy link
Member

hughsie commented Jul 27, 2023

@vmatare did you create the ESP partition, or did Anaconda do it for you?

@vmatare
Copy link
Author

vmatare commented Aug 1, 2023

@vmatare did you create the ESP partition, or did Anaconda do it for you?

I'm pretty sure Anaconda did it. After I got this message from fwupd, I noticed that it had a weird type flag (I think it was 0x04, which fdisk says is FAT16 <32M). I then tried both 0xef and 0x0b, but none of that made any difference. Currently I have the following:

# fdisk -l /dev/nvme0n1
Disk /dev/nvme0n1: 238.47 GiB, 256060514304 bytes, 500118192 sectors
Disk model: ADATA SX8000NP                          
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x772dea53

Device         Boot   Start       End   Sectors   Size Id Type
/dev/nvme0n1p1 *       2048   1230847   1228800   600M ef EFI (FAT-12/16/32)
/dev/nvme0n1p2      1230848   3327999   2097152     1G 83 Linux
/dev/nvme0n1p3      3328000 500117503 496789504 236.9G 8e Linux LVM

So apparently it's not even a GPT partitioning scheme. Anaconda might have just left it the way it was before. But normally GPT shouldn't be strictly necessary, right?

@hughsie
Copy link
Member

hughsie commented Aug 2, 2023

The firmware used to not care, but it seems more and more firmware does nowadays. It's probably more because it's not being tested on MBR partitions anymore. If firmware updates do work for you it's safe to ignore.

@XenonSup
Copy link

XenonSup commented Sep 29, 2023

I'm having the same problem.

Describe the bug
Same as above

Steps to Reproduce
Same as above

Expected behavior
Same as above. Or display no warnings.

fwupd version information

$ fwupdmgr --version
compile   org.freedesktop.fwupd         1.9.5
compile   com.hughsie.libxmlb           0.3.12
compile   com.hughsie.libjcat           0.1.13
runtime   org.freedesktop.fwupd-efi     1.4
compile   org.freedesktop.gusb          0.4.5
runtime   com.hughsie.libjcat           0.1.13
runtime   org.freedesktop.gusb          0.4.5
runtime   org.freedesktop.fwupd         1.9.5
runtime   org.kernel                    6.5.5-200.fc38.x86_64

Please note how you installed it (apt, dnf, pacman, source, etc): dnf

fwupd device information

$ fwupdmgr get-devices --show-all-devices
WARNING: UEFI ESP partition may not be set up correctly
See https://github.com/fwupd/fwupd/wiki/PluginFlag:esp-not-valid for more information.
Dell Inc. XPS 15 9560
│
├─Core™ i7-7700HQ CPU @ 2.80GHz:
│     Device ID:          4bde70ba4e39b28f9eab1628f9dd6e6244c03027
│     Current version:    0x000000f4
│     Vendor:             Intel
│     GUIDs:              b9a2dd81-159e-5537-a7db-e7101d164d3f ← cpu
│                         30249f37-d140-5d3e-9319-186b1bd5cac3 ← CPUID\PRO_0&FAM_06
│                         809a0b93-8a12-5338-a571-ad5583acf896 ← CPUID\PRO_0&FAM_06&MOD_9E
│                         d0f754d5-1395-5573-bc83-85ba955da70a ← CPUID\PRO_0&FAM_06&MOD_9E&STP_9
│     Device Flags:       • Internal device
│   
├─GP107M [GeForce GTX 1050 Mobile]:
│     Device ID:          ce4c74a5188d5b9cdb1e72ed32dad2d313c1c999
│     Current version:    a1
│     Vendor:             NVIDIA Corporation (PCI:0x10DE, PCI:0x8086)
│     GUIDs:              ef41e989-4e6e-560d-a860-ea71aa8c21a3 ← PCI\VEN_10DE&DEV_1C8D
│                         5fdc8f12-8985-5dcb-95ea-5761f769cb4d ← PCI\VEN_10DE&DEV_1C8D&SUBSYS_102807BE
│                         d29269b6-e458-5f45-975c-9d52bb38e35f ← PCI\VEN_8086&DEV_1901
│                         6949aa50-f4e1-578b-81c8-d8c61915cfe2 ← PCI\VEN_8086&DEV_1901&SUBSYS_102807BE
│     Device Flags:       • Internal device
│                         • Cryptographic hash verification is available
│   
├─HD Graphics 630:
│     Device ID:          5792b48846ce271fab11c4a545f7a3df0d36e00a
│     Current version:    04
│     Vendor:             Intel Corporation (PCI:0x8086)
│     GUIDs:              f744dc01-a247-5543-b9db-2adba3091233 ← PCI\VEN_8086&DEV_591B
│                         089d6890-1705-50c9-92bd-55a1bd648ed9 ← PCI\VEN_8086&DEV_591B&SUBSYS_102807BE
│     Device Flags:       • Internal device
│                         • Cryptographic hash verification is available
│   
├─SHGP31-1000GM:
│     Device ID:          04e17fcf7d3de91da49a163ffe4907855c3648be
│     Summary:            NVM Express solid state drive
│     Current version:    41062C20
│     Vendor:             SK hynix (NVME:0x1C5C)
│     Serial Number:      ASACN55231020CE1M
│     GUIDs:              0ee57466-ca9d-5f10-a005-ec6bacf6fb82 ← NVME\VEN_1C5C&DEV_174A
│                         34e06406-f620-5b9d-a9cd-7f3a4e648633 ← NVME\VEN_1C5C&DEV_174A&SUBSYS_1C5C174A
│                         c555ec26-0c1b-5724-97ac-01bf179af935 ← SHGP31-1000GM
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Signed Payload
│   
└─System Firmware:
  │   Device ID:          a45df35ac0e948ee180fe216a5f703f32dda163f
  │   Summary:            UEFI ESRT device
  │   Current version:    1.31.0
  │   Minimum Version:    1.31.0
  │   Vendor:             Dell (DMI:Dell Inc.)
  │   Update State:       Success
  │   GUIDs:              34578c72-11dc-4378-bc7f-b643866f598c
  │                       230c8b18-8d9b-53ec-838b-6cfc0383493a ← main-system-firmware
  │   Device Flags:       • Internal device
  │                       • Updatable
  │                       • System requires external power source
  │                       • Supported on remote server
  │                       • Needs a reboot after installation
  │                       • Device is usable for the duration of the update
  │ 
  ├─AMT [unprovisioned]:
  │     Device ID:        8d5470e73fd9a31eaa460b2b6aea95483fe3f14c
  │     Summary:          Hardware and firmware technology for remote out-of-band management
  │     Current version:  11.8.93.4323
  │     Bootloader Version:11.8.93.4323
  │     Vendor:           Intel Corporation (MEI:0x8086)
  │     GUIDs:            12f80028-b4b7-4b2d-aca8-46e0ff65814c
  │                       d39310dc-e5d7-5eb2-945d-22011cbd3157 ← MEI\VEN_8086&DEV_A13A
  │                       fdb39475-3243-525a-915e-26ebf8a413bb ← MEI\VEN_8086&DEV_A13A&SUBSYS_102807BE
  │     Device Flags:     • Internal device
  │   
  ├─UEFI Platform Key:
  │     Device ID:        6924110cde4fa051bfdc600a60620dc7aa9d3c6a
  │     Summary:          Dell Inc. Platform Key
  │     Vendor:           Dell Inc.
  │     GUID:             5f7cc4ea-9f7a-5c5f-b535-dfbcc73f5ba6 ← UEFI\CRT_2493B118EABD632FD3BA49C333A8329B1982E872
  │   
  └─UEFI dbx:
        Device ID:        362301da643102b9f38477387e2193e57abaa590
        Summary:          UEFI revocation database
        Current version:  220
        Minimum Version:  220
        Vendor:           UEFI:Linux Foundation
        Install Duration: 1 second
        GUIDs:            00fe3755-a4d8-5ef7-ba5f-47979fbb3423 ← UEFI\CRT_E28D59CA489BD2AD580F2EA5D62D6A29BB9C02AE5A818434A37DA7FC11DFF9E9
                          4a6cd2cb-8741-5257-9d1f-89a275dacca7 ← UEFI\CRT_E28D59CA489BD2AD580F2EA5D62D6A29BB9C02AE5A818434A37DA7FC11DFF9E9&ARCH_X64
                          c6682ade-b5ec-57c4-b687-676351208742 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503
                          f8ba2887-9411-5c36-9cee-88995bb39731 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503&ARCH_X64
        Device Flags:     • Internal device
                          • Updatable
                          • Supported on remote server
                          • Needs a reboot after installation
                          • Device is usable for the duration of the update
                          • Only version upgrades are allowed
                          • Signed Payload
      

Additional questions

  • Operating system and version: Fedora 38
  • Have you tried rebooting?: Yes
  • Is this a regression?: Might be in some sense. I don't remember seeing this the last time I used it, which was a while back on Fedora 37.
  • Did you create the ESP partition? No, it was created by the Windows installer (I'm dual-booting), but it has the esp flag on

Interestingly, my FAT32 Basic Data partition (7) is listed alongside my actual ESP (1) when listing

esp-list

# fwupdtool esp-list --verbose
14:25:46.787 FuDebug              verbose to info (on console 1)
14:25:46.787 FuEngine             starting fwupd 1.9.5…
0.	Cancel
1.	/org/freedesktop/UDisks2/block_devices/nvme0n1p1
2.	/org/freedesktop/UDisks2/block_devices/nvme0n1p7
Choose volume [0-2]: 1
/boot/efi/EFI/Microsoft/Boot/BCD
/boot/efi/EFI/Microsoft/Boot/BCD.LOG
/boot/efi/EFI/Microsoft/Boot/BCD.LOG1
/boot/efi/EFI/Microsoft/Boot/BCD.LOG2
/boot/efi/EFI/Microsoft/Boot/bg-BG/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/bg-BG/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/kd_02_10df.dll
/boot/efi/EFI/Microsoft/Boot/CIPolicies/Active/{82443e1e-8a39-4b4a-96a8-f40ddc00b9f3}.cip
/boot/efi/EFI/Microsoft/Boot/CIPolicies/Active/{CDD5CB55-DB68-4D71-AA38-3DF2B6473A52}.cip
/boot/efi/EFI/Microsoft/Boot/CIPolicies/Active/{5DAC656C-21AD-4A02-AB49-649917162E70}.cip
/boot/efi/EFI/Microsoft/Boot/cs-CZ/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/cs-CZ/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/cs-CZ/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/da-DK/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/da-DK/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/da-DK/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/de-DE/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/de-DE/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/de-DE/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/el-GR/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/el-GR/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/el-GR/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/en-GB/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/en-GB/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/en-US/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/en-US/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/en-US/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/es-ES/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/es-ES/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/es-ES/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/es-MX/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/es-MX/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/et-EE/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/et-EE/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/fi-FI/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/fi-FI/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/fi-FI/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/fr-CA/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/fr-CA/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/fr-FR/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/fr-FR/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/fr-FR/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/hr-HR/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/hr-HR/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/hu-HU/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/hu-HU/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/hu-HU/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/it-IT/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/it-IT/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/it-IT/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/ja-JP/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/ja-JP/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/ja-JP/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/kd_02_10ec.dll
/boot/efi/EFI/Microsoft/Boot/kd_02_1137.dll
/boot/efi/EFI/Microsoft/Boot/kd_02_14e4.dll
/boot/efi/EFI/Microsoft/Boot/kd_02_15b3.dll
/boot/efi/EFI/Microsoft/Boot/kd_02_1969.dll
/boot/efi/EFI/Microsoft/Boot/kd_02_19a2.dll
/boot/efi/EFI/Microsoft/Boot/kd_02_1af4.dll
/boot/efi/EFI/Microsoft/Boot/kd_02_8086.dll
/boot/efi/EFI/Microsoft/Boot/kd_07_1415.dll
/boot/efi/EFI/Microsoft/Boot/kd_0C_8086.dll
/boot/efi/EFI/Microsoft/Boot/winsipolicy.p7b
/boot/efi/EFI/Microsoft/Boot/bootmgfw.efi
/boot/efi/EFI/Microsoft/Boot/bootmgr.efi
/boot/efi/EFI/Microsoft/Boot/kdstub.dll
/boot/efi/EFI/Microsoft/Boot/memtest.efi
/boot/efi/EFI/Microsoft/Boot/ko-KR/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/ko-KR/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/ko-KR/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/lt-LT/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/lt-LT/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/lv-LV/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/lv-LV/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/boot.stl
/boot/efi/EFI/Microsoft/Boot/nb-NO/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/nb-NO/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/nb-NO/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/nl-NL/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/nl-NL/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/nl-NL/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/pl-PL/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/pl-PL/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/pl-PL/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/pt-BR/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/pt-BR/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/pt-BR/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/pt-PT/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/pt-PT/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/pt-PT/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/qps-ploc/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/ro-RO/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/ro-RO/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/ru-RU/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/ru-RU/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/ru-RU/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/sk-SK/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/sk-SK/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/sl-SI/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/sl-SI/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/sr-Latn-RS/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/sr-Latn-RS/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/sv-SE/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/sv-SE/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/sv-SE/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/tr-TR/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/tr-TR/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/tr-TR/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/uk-UA/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/uk-UA/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/kdnet_uart16550.dll
/boot/efi/EFI/Microsoft/Boot/zh-CN/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/zh-CN/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/zh-CN/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/zh-TW/bootmgfw.efi.mui
/boot/efi/EFI/Microsoft/Boot/zh-TW/bootmgr.efi.mui
/boot/efi/EFI/Microsoft/Boot/zh-TW/memtest.efi.mui
/boot/efi/EFI/Microsoft/Boot/BOOTSTAT.DAT
/boot/efi/EFI/Microsoft/Boot/Fonts/meiryo_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/msjhn_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/msjh_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/msyhn_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/msyh_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/segmono_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/segoen_slboot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/segoe_slboot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/wgl4_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/chs_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/cht_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/jpn_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/kor_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/malgunn_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/malgun_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Fonts/meiryon_boot.ttf
/boot/efi/EFI/Microsoft/Boot/Resources/en-US/bootres.dll.mui
/boot/efi/EFI/Microsoft/Boot/Resources/bootres.dll
/boot/efi/EFI/Microsoft/Boot/FveTcg_0.log
/boot/efi/EFI/Microsoft/Boot/FveTcg_1.log
/boot/efi/EFI/Microsoft/Boot/FveTcg_2.log
/boot/efi/EFI/Microsoft/Boot/cbmr_driver.efi
/boot/efi/EFI/Microsoft/Recovery/BCD
/boot/efi/EFI/Microsoft/Recovery/BCD.LOG
/boot/efi/EFI/Microsoft/Recovery/BCD.LOG1
/boot/efi/EFI/Microsoft/Recovery/BCD.LOG2
/boot/efi/EFI/Boot/BOOTIA32.EFI
/boot/efi/EFI/Boot/fbia32.efi
/boot/efi/EFI/Boot/fbx64.efi
/boot/efi/EFI/Boot/bootx64.efi
/boot/efi/EFI/fedora/grub.cfg
/boot/efi/EFI/fedora/fw/fwupd-34578c72-11dc-4378-bc7f-b643866f598c.cap
/boot/efi/EFI/fedora/fwupdx64.efi
/boot/efi/EFI/fedora/BOOTIA32.CSV
/boot/efi/EFI/fedora/BOOTX64.CSV
/boot/efi/EFI/fedora/gcdia32.efi
/boot/efi/EFI/fedora/gcdx64.efi
/boot/efi/EFI/fedora/grubia32.efi
/boot/efi/EFI/fedora/grubx64.efi
/boot/efi/EFI/fedora/mmia32.efi
/boot/efi/EFI/fedora/mmx64.efi
/boot/efi/EFI/fedora/shim.efi
/boot/efi/EFI/fedora/shimia32.efi
/boot/efi/EFI/fedora/shimx64.efi
/boot/efi/EFI/Dell/Bios/Recovery/BIOS_CUR.RCV
/boot/efi/System/Library/CoreServices/SystemVersion.plist
/boot/efi/mach_kernel

Disk & Partition Layout

# fdisk -l /dev/nvme0n1
Disk /dev/nvme0n1: 931.51 GiB, 1000204886016 bytes, 1953525168 sectors
Disk model: SHGP31-1000GM                           
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 79A74495-8B87-4541-B365-F309CF6247EB

Device              Start        End    Sectors   Size Type
/dev/nvme0n1p1       2048     206847     204800   100M EFI System
/dev/nvme0n1p2     206848     239615      32768    16M Microsoft reserved
/dev/nvme0n1p3     239616  522866687  522627072 249.2G Microsoft basic data
/dev/nvme0n1p4  522866688  524523519    1656832   809M Windows recovery environment
/dev/nvme0n1p5  524525568  526622719    2097152     1G Linux filesystem
/dev/nvme0n1p6  526622720 1758902271 1232279552 587.6G Linux filesystem
/dev/nvme0n1p7 1758902272 1953523711  194621440  92.8G Microsoft basic data

# parted --list
Model: SHGP31-1000GM (nvme)
Disk /dev/nvme0n1: 1000GB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags: 

Number  Start   End     Size    File system  Name                          Flags
 1      1049kB  106MB   105MB   fat32        EFI System Partition          boot, esp, no_automount
 2      106MB   123MB   16.8MB               Microsoft reserved partition  msftres, no_automount
 3      123MB   268GB   268GB   ntfs         Basic data partition          msftdata, no_automount
 4      268GB   269GB   848MB   ntfs                                       hidden, diag, no_automount
 5      269GB   270GB   1074MB  ext4
 6      270GB   901GB   631GB
 7      901GB   1000GB  99.6GB  fat32                                      msftdata
...

@rehrauer
Copy link

I have the same problem. I believe that fwupd thinks that a partition with the msftdata flag set is an EFI partition. I do not run windows only linux on my laptop but have a recovery partition with the msftdata flag set. fwupdtool esp-list --verbose also lists my recovery partition along with my 2 EFI partitions. This only happens with fedora. I have debian running on another partition and do not get any error when running debian. It also does not happen with ubuntu. I can do firmware updates from ubuntu or debian but the only one I attempted from fedora 38 hung my system.

@T0MuX
Copy link

T0MuX commented Dec 5, 2023

[ EDIT : SOLVED TO ME ]
[ I just added the "esp" flag on my EFI partition ... lol ]

Hi, I have exactly the same issue, even a bit worse.

  • Archlinux freshly updated, linux 6.1.64-1-lts
  • Udisks is installed.
  • EFI partition is mounted on boot via fstab.
  • Already edited /etc/fwupd/uefi_capsule.conf to add OverrideESPMountPoint=/boot/efi (which is the mount point of my EFI partition), but when I restart the fwupd service, the config file gets renamed into /etc/fwupd/uefi_capsule.conf.old with no change at all (still not working properly).
[t0mux@BCD-GAP-L004 ~]$ cat /etc/fstab | grep vfat
UUID=0FF4-FC82      	/boot/efi 	vfat      	rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro	0 2


[t0mux@BCD-GAP-L004 ~]$ sudo fwupdtool esp-list --verbose
05:08:29.197 FuDebug              verbose to info (on console 1)
05:08:29.198 FuEngine             starting fwupd 1.9.9…
No ESP or BDP found


[t0mux@BCD-GAP-L004 ~]$ sudo fdisk -l
Disque /dev/nvme0n1 : 476,94 GiB, 512110190592 octets, 1000215216 secteurs
Modèle de disque : KBG50ZNT512G LS KIOXIA                  
Unités : secteur de 1 × 512 = 512 octets
Taille de secteur (logique / physique) : 512 octets / 512 octets
taille d'E/S (minimale / optimale) : 512 octets / 512 octets
Type d'étiquette de disque : gpt
Identifiant de disque : 650E1D25-1BA0-4B12-82EA-9F4A255C2E11

Périphérique     Début        Fin  Secteurs Taille Type
/dev/nvme0n1p1      34     585937    585904 286,1M Système de fichiers Linux
/dev/nvme0n1p2 1048576 1000214527 999165952 476,4G Système de fichiers Linux


[t0mux@BCD-GAP-L004 ~]$ ls /boot/efi
EFI

[t0mux@BCD-GAP-L004 ~]$ ls /boot/efi/EFI/
BOOT  crystal

[t0mux@BCD-GAP-L004 ~]$ ls /boot/efi/EFI/BOOT/
BOOTX64.EFI

[t0mux@BCD-GAP-L004 ~]$ ls /etc/fwupd/
bios-settings.d  fwupd.conf  remotes.d  uefi_capsule.conf.old

-------------- EDIT (after added "esp" flag on EFI partition) --------------------

[t0mux@BCD-GAP-L004 ~]$ sudo fwupdtool esp-list --verbose
05:10:15.045 FuDebug              verbose to info (on console 1)
05:10:15.045 FuEngine             starting fwupd 1.9.9…
Volume sélectionné: /org/freedesktop/UDisks2/block_devices/nvme0n1p1
/boot/efi/EFI/BOOT/BOOTX64.EFI
/boot/efi/EFI/crystal/grubx64.efi

@tomhughes
Copy link

Also broken for me, and I do have the esp flag:

arden [~] % sudo fwupdmgr          
WARNING: UEFI ESP partition may not be set up correctly
See https://github.com/fwupd/fwupd/wiki/PluginFlag:esp-not-valid for more information.
Command not found

Use fwupdmgr --help for help

arden [~] % sudo parted -l /dev/nvme0n1
Model: THNSN5512GPUK NVMe TOSHIBA 512GB (nvme)
Disk /dev/nvme0n1: 512GB
Sector size (logical/physical): 512B/512B
Partition Table: gpt
Disk Flags: 

Number  Start   End     Size    File system     Name                  Flags
 1      1049kB  630MB   629MB   fat32           EFI System Partition  boot, esp
 2      630MB   3851MB  3221MB  fat32           Basic data partition  msftdata
 3      3851MB  478GB   474GB   ext4
 4      478GB   512GB   34.1GB  linux-swap(v1)                        swap

arden [~] % sudo fwupdtool esp-list
0.	Cancel
1.	/org/freedesktop/UDisks2/block_devices/nvme0n1p1
2.	/org/freedesktop/UDisks2/block_devices/nvme0n1p2
Choose volume [0-2]: 1
/boot/efi/EFI/BOOT/BOOTX64.EFI
/boot/efi/EFI/BOOT/fbx64.efi
/boot/efi/EFI/fedora/fw/fwupd-3b8c8162-188c-46a4-aec9-be43f1d65697.cap
/boot/efi/EFI/fedora/fw/fwupd-5ffdbc0d-f340-441c-a803-8439c8c0ae10.cap
/boot/efi/EFI/fedora/fwupdx64.efi
/boot/efi/EFI/fedora/shim.efi
/boot/efi/EFI/fedora/BOOTX64.CSV
/boot/efi/EFI/fedora/mmx64.efi
/boot/efi/EFI/fedora/grubx64.efi
/boot/efi/EFI/fedora/grub.cfg
/boot/efi/EFI/fedora/shimx64.efi
/boot/efi/EFI/Dell/Bios/Recovery/BIOS_PRE.rcv
/boot/efi/EFI/Dell/Bios/Recovery/BIOS_CUR.RCV
/boot/efi/EFI/Dell/logs/diags_previous.xml
/boot/efi/EFI/Dell/logs/diags_current.xml

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

WARNING: UEFI ESP partition may not be set up correctly

So we're showing that as we've chosen the msftdata partition (presumably because it's bigger - and also has linux-related files on it) which doesn't have the ESP flag set. Could you try with #6507 and then get me the output of sudo fwupdtool --plugins uefi_capsule get-devices -vv -- the bit I need is:

11:06:12.381 FuPluginUefiCapsule  found /boot/efi/EFI/fedora/grubx64.efi which indicates a Linux ESP, using /boot/efi
11:06:12.381 FuPluginUefiCapsule  more than one ESP possible:
 - 0x10258:	/org/freedesktop/UDisks2/block_devices/nvme1n1p1
 - 0x64:	/org/freedesktop/UDisks2/block_devices/nvme0n1p1

@tomhughes
Copy link

Yes that patch fixes it - this is the output:

11:55:49.507 FuPluginUefiCapsule  found /boot/efi/EFI/fedora/grubx64.efi which indicates a Linux ESP, using /boot/efi
11:55:49.507 FuVolume             mounting /org/freedesktop/UDisks2/block_devices/nvme0n1p2
11:55:49.681 FuPluginUefiCapsule  found /run/media/root/OS/efi.factory/boot/grubx64.efi which indicates a Linux ESP, using /run/media/root/OS
11:55:49.681 FuVolume             unmounting /org/freedesktop/UDisks2/block_devices/nvme0n1p2
11:55:49.718 FuPluginUefiCapsule  more than one ESP possible:
 - 0x30258:	/org/freedesktop/UDisks2/block_devices/nvme0n1p1
 - 0x10c00:	/org/freedesktop/UDisks2/block_devices/nvme0n1p2

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

OS/efi.factory/boot

Is that a recovery partition?

@tomhughes
Copy link

I believe so yes - it's a Dell XPS 13 developer edition so it came with Ubuntu and I reinstalled with Fedora but I probably just left the recovery partition alone.

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

Can you get us the partition "Name" please? We're already ignoring Recovery Partition -- udisksctl dump would tell you.

@tomhughes
Copy link

The first partition (the real ESP ) seems to be called "EFI System Partition" and the second partition (the msftdata one) is called "Basic data partition".

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

Basic data partition

Bleh, that's the fallback IIRC for when the name isn't set. Maybe the UUID is something we could key-from? i.e. if you google your UUID from org.freedesktop.UDisks2.Partition is it obviously just dd'd in the factory?

@tomhughes
Copy link

The UUID is f618a4bd-8b4f-4c55-a88f-c88a8365c58d which doesn't seem to get any hits at all...

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

which doesn't seem to get any hits at all

So random -- which is probably good I suppose. Okay, no further action required, thanks!

@superm1
Copy link
Member

superm1 commented Dec 7, 2023

IIRC Dell recovery partition labels are "OS".
@CragW fyi you should consider this thread in your backports idea.

@diegorondini
Copy link

Hi,

same situation, Dell XPS 13 9370 preloaded with Ubuntu reinstalled with Fedora.
The GPT partition label is indeed Basic data partition, but FAT filesystem label is OS:

[root@localhost ~]# ll /dev/disk/by-partlabel/Basic\\x20data\\x20partition
lrwxrwxrwx. 1 root root 15 Dec  6 08:55 '/dev/disk/by-partlabel/Basic\x20data\x20partition' -> ../../nvme0n1p2
[root@localhost ~]# ll /dev/disk/by-label/OS
lrwxrwxrwx. 1 root root 15 Dec  6 08:55 /dev/disk/by-label/OS -> ../../nvme0n1p2
[root@localhost ~]# dosfslabel /dev/nvme0n1p2 
OS

Regards

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

@diegorondini is the Name in org.freedesktop.UDisks2.Partition when running udisksctl dump? @superm1 do you think it makes sense to add to the ignorelist?

@diegorondini
Copy link

$ udisksctl dump
[...]
/org/freedesktop/UDisks2/block_devices/nvme0n1p2:
  org.freedesktop.UDisks2.Block:
    Configuration:              []
    CryptoBackingDevice:        '/'
    Device:                     /dev/nvme0n1p2
    DeviceNumber:               66306
    Drive:                      '/org/freedesktop/UDisks2/drives/<my-drive-name>'
    HintAuto:                   false
    HintIconName:               
    HintIgnore:                 false
    HintName:                   
    HintPartitionable:          true
    HintSymbolicIconName:       
    HintSystem:                 true
    Id:                         by-id-nvme-<my-drive-name>-part2
    IdLabel:                    OS
    IdType:                     vfat
    IdUUID:                     36F6-FA11
    IdUsage:                    filesystem
    IdVersion:                  FAT32
    MDRaid:                     '/'
    MDRaidMember:               '/'
    PreferredDevice:            /dev/nvme0n1p2
    ReadOnly:                   false
    Size:                       5368709120
    Symlinks:                   /dev/disk/by-diskseq/1-part2
                                /dev/disk/by-id/nvme-<my-drive-name>-part2
                                /dev/disk/by-id/nvme-<my-drive-name>_1-part2
                                /dev/disk/by-id/nvme-eui.000000000000001000080d050004c3cd-part2
                                /dev/disk/by-label/OS
                                /dev/disk/by-partlabel/Basic\x20data\x20partition
                                /dev/disk/by-partuuid/2df092f5-bf25-4745-ac17-ed1170225ea0
                                /dev/disk/by-path/pci-0000:6e:00.0-nvme-1-part2
                                /dev/disk/by-uuid/36F6-FA11
    UserspaceMountOptions:      
  org.freedesktop.UDisks2.Filesystem:
    MountPoints:        
    Size:               0
  org.freedesktop.UDisks2.Partition:
    Flags:              0
    IsContained:        false
    IsContainer:        false
    Name:               Basic data partition
    Number:             2
    Offset:             787480576
    Size:               5368709120
    Table:              '/org/freedesktop/UDisks2/block_devices/nvme0n1'
    Type:               ebd0a0a2-b9e5-4433-87c0-68b6b72699c7
    UUID:               2df092f5-bf25-4745-ac17-ed1170225ea0

@superm1
Copy link
Member

superm1 commented Dec 7, 2023

@diegorondini is the Name in org.freedesktop.UDisks2.Partition when running udisksctl dump? @superm1 do you think it makes sense to add to the ignorelist?

I could do one better. Here's a relatively complete ignore list:
https://github.com/storaged-project/udisks/blob/master/data/80-udisks2.rules#L158

@superm1
Copy link
Member

superm1 commented Dec 7, 2023

I almost wonder if UDISKS_IGNORE would be worth using but I'm pretty sure it will catch real ESP's too then.

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

UDISKS_IGNORE doesn't work indeed as https://github.com/storaged-project/udisks/blob/master/data/80-udisks2.rules#L136 but Recovery|RECOVERY|Lenovo_Recovery|HP_RECOVERY|Recovery_Partition|DellUtility|DellRestore|IBM_SERVICE|SERVICEV001|SERVICEV002|SYSTEM_RESERVED|System_Reserved|WINRE_DRV|DIAGS|IntelRST makes sense to me. @superm1 shall I do a PR with all those?

@hughsie
Copy link
Member

hughsie commented Dec 7, 2023

e.g. like #6512 perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

8 participants