Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME Software shows failed to build result for 362301da643102b9f38477387e2193e57abaa590 #6101

Closed
bbhtt opened this issue Aug 18, 2023 · 37 comments · Fixed by #6104
Closed
Labels

Comments

@bbhtt
Copy link

bbhtt commented Aug 18, 2023

Describe the bug

After upgrading from Fedora 38 to Fedora 39 beta, GNOME software on each login shows the following warning:

image

Searching for the id and looking at https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1163 suggests it is coming from fwupd (UEFI DBX Device Id). But none of the fwupdmgr cli commands shows anything actionable or any errors.

I've tried reinstalling it with sudo fwupdmgr reinstall, but the error comes up again on next restart.

What's the cause and what would be the way to resolve it?

Thanks!

Steps to Reproduce

Upgrade from Fedora 38 to 39 beta

Expected behavior

Shouldn't show any warning

fwupd version information
Please provide the version of the daemon and client.

fwupdmgr --version
compile   org.freedesktop.fwupd         1.9.3
compile   com.hughsie.libxmlb           0.3.11
compile   com.hughsie.libjcat           0.1.14
runtime   org.freedesktop.fwupd-efi     1.4
compile   org.freedesktop.gusb          0.4.6
runtime   com.hughsie.libjcat           0.1.14
runtime   org.freedesktop.gusb          0.4.6
runtime   org.freedesktop.fwupd         1.9.3
runtime   org.kernel                    6.5.0-0.rc6.43.fc39.x86_64

Please note how you installed it (apt, dnf, pacman, source, etc): dnf

**fwupd device information**

Please provide the output of the fwupd devices recognized in your system.

fwupdmgr get-devices --show-all-devices
Gigabyte Technology Co., Ltd. B450M DS3H WIFI
│
├─Unknown Device:
│     Device ID:          a29de8124928f7dc31db026069ac1d601a56056f
│     GUID:               2d9ac22e-0ffe-5691-9e21-f9fecce8761c ← GPIO\ID_AMDIF030:00
│   
├─400 Series Chipset SATA Controller:
│     Device ID:          7d29f2075dcafb4488b40c73f199cf46bb76bddb
│     Current version:    01
│     Vendor:             Advanced Micro Devices, Inc. [AMD] (PCI:0x1022)
│     GUIDs:              40dd51ce-4d2b-5863-a55b-e5e05b828e18 ← PCI\VEN_1022&DEV_43C8
│                         b315bc76-8da0-5bc6-82e8-296673694802 ← PCI\VEN_1022&DEV_43C8&SUBSYS_1B211062
│                         abcaf57e-ca4a-5f11-8dde-8b75cb993f28 ← PCI\VEN_1022&DEV_1634
│                         467ef116-7254-5747-9b3a-7e92b68def61 ← PCI\VEN_1022&DEV_1634&SUBSYS_10221453
│     Device Flags:       • Internal device
│                         • Cryptographic hash verification is available
│   
├─AMD Ryzen 5 5600G with Radeon Graphics:
│ │   Device ID:          4bde70ba4e39b28f9eab1628f9dd6e6244c03027
│ │   Current version:    0x0a50000d
│ │   Vendor:             Advanced Micro Devices, Inc.
│ │   GUIDs:              b9a2dd81-159e-5537-a7db-e7101d164d3f ← cpu
│ │                       22f9ecf4-588d-5c0a-8326-6ebff3655c6d ← CPUID\PRO_0&FAM_19
│ │                       79759cdc-94db-5098-be7b-eb02521fbbec ← CPUID\PRO_0&FAM_19&MOD_50
│ │                       20b595b0-5892-5870-8e4c-688133ad6e34 ← CPUID\PRO_0&FAM_19&MOD_50&STP_0
│ │   Device Flags:       • Internal device
│ │ 
│ ├─GPIO controller:
│ │     Device ID:        f685512aa07369c9e77742acef941d779d31e766
│ │     GUID:             37b440a9-2473-5087-a39b-db84f32a8ed8 ← GPIO\ID_AMDI0030:00
│ │   
│ ├─Graphics Processing Unit (GPU):
│ │     Device ID:        d62bbbab5045e98c4f26c1dcac8b2ee96a3d90e4
│ │     Current version:  13-CEZANNE-019
│ │     Vendor:           Advanced Micro Devices, Inc. [AMD/ATI] (PCI:0x1002)
│ │     GUIDs:            9c2b91ed-2a3a-570a-9451-f509beda7125 ← PCI\VEN_1002&DEV_1638
│ │                       0f6f7b9b-7582-5cc2-b617-734f0723ffff ← PCI\VEN_1002&DEV_1638&SUBSYS_1458D000
│ │     Device Flags:     • Internal device
│ │   
│ └─Secure Processor:
│       Device ID:        c54ab0237d7a8db8c717b68e0be78e4374a2a079
│       Vendor:           Advanced Micro Devices, Inc. (PCI:0x1022)
│       GUIDs:            0e8dc554-a0a2-51fb-b439-1eb72b14ec38 ← PCI\VEN_1022&DEV_15DF
│                         bd5a5081-60b8-57cb-91d6-78e850123204 ← PCI\VEN_1022&DEV_15DF&SUBSYS_102215DF
│       Device Flags:     • Internal device
│     
├─CT500P3SSD8:
│     Device ID:          e6b39964e9afdb51007551470f6c79a2e720fd08
│     Summary:            NVM Express solid state drive
│     Current version:    P9CR30A
│     Vendor:             Micron/Crucial Technology (NVME:0xC0A9)
│     Serial Number:      2310E6B85A85
│     GUIDs:              024834f2-5768-5565-b929-e3f57c0fcd69 ← NVME\VEN_C0A9&DEV_540A
│                         6d4f3936-021a-57df-bbd9-493e8f74da7e ← NVME\VEN_C0A9&DEV_540A&SUBSYS_C0A95021
│                         2e2ce095-e759-50d2-ae68-11a936c95e2b ← CT500P3SSD8
│     Device Flags:       • Internal device
│                         • Updatable
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│   
├─TPM:
│     Device ID:          c6a80ac3a22083423992a3cb15018989f37834d6
│     Summary:            TPM 2.0 Device
│     Current version:    3.87.0.5
│     Vendor:             Advanced Micro Devices, Inc. (TPM:AMD)
│     GUIDs:              ff71992e-52f7-5eea-94ef-883e56e034c6 ← system-tpm
│                         9305de1c-1e12-5665-81c4-37f8e51219b8 ← TPM\VEN_AMD&DEV_0001
│                         78a291ae-b499-5b0f-8f1d-74e1fefd0b1c ← TPM\VEN_AMD&MOD_AMD
│                         65a3fced-b423-563f-8098-bf5c329fc063 ← TPM\VEN_AMD&DEV_0001&VER_2.0
│                         5e704f0d-83cb-5364-8384-f46d725a23b8 ← TPM\VEN_AMD&MOD_AMD&VER_2.0
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device can recover flash failures
│                         • Full disk encryption secrets may be invalidated when updating
│                         • Signed Payload
│   
├─UEFI Platform Key:
│     Device ID:          6924110cde4fa051bfdc600a60620dc7aa9d3c6a
│     Summary:            GIGABYTE
│     GUID:               3184bd50-b815-5656-a3dc-6b591607879d ← UEFI\CRT_897FB5900210D26D610F43FC9C3174791A800621
│   
└─UEFI dbx:
      Device ID:          362301da643102b9f38477387e2193e57abaa590
      Summary:            UEFI revocation database
      Current version:    371
      Minimum Version:    371
      Vendor:             UEFI:Linux Foundation
      Install Duration:   1 second
      GUIDs:              c6682ade-b5ec-57c4-b687-676351208742 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503
                          f8ba2887-9411-5c36-9cee-88995bb39731 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503&ARCH_X64
      Device Flags:       • Internal device
                          • Updatable
                          • Supported on remote server
                          • Needs a reboot after installation
                          • Device is usable for the duration of the update
                          • Only version upgrades are allowed
                          • Signed Payload

System UEFI configuration
Please provide the output of the following commands:

efibootmgr -v
BootCurrent: 0003
Timeout: 1 seconds
BootOrder: 0003,0004
Boot0003* Fedora	HD(1,GPT,32bf58de-c059-4f19-b1de-e1f00a6235db,0x800,0x12c000)/File(\EFI\FEDORA\SHIMX64.EFI)
      dp: 04 01 2a 00 01 00 00 00 00 08 00 00 00 00 00 00 00 c0 12 00 00 00 00 00 de 58 bf 32 59 c0 19 4f b1 de e1 f0 0a 62 35 db 02 02 / 04 04 34 00 5c 00 45 00 46 00 49 00 5c 00 46 00 45 00 44 00 4f 00 52 00 41 00 5c 00 53 00 48 00 49 00 4d 00 58 00 36 00 34 00 2e 00 45 00 46 00 49 00 00 00 / 7f ff 04 00
Boot0004* Fedora	HD(1,GPT,32bf58de-c059-4f19-b1de-e1f00a6235db,0x800,0x12c000)/File(\EFI\FEDORA\SHIM.EFI)0000424f
      dp: 04 01 2a 00 01 00 00 00 00 08 00 00 00 00 00 00 00 c0 12 00 00 00 00 00 de 58 bf 32 59 c0 19 4f b1 de e1 f0 0a 62 35 db 02 02 / 04 04 2e 00 5c 00 45 00 46 00 49 00 5c 00 46 00 45 00 44 00 4f 00 52 00 41 00 5c 00 53 00 48 00 49 00 4d 00 2e 00 45 00 46 00 49 00 00 00 / 7f ff 04 00
    data: 00 00 42 4f
efivar -l | grep fw

Shows nothing
tree /boot
/boot
|-- System.map-6.4.10-200.fc38.x86_64
|-- System.map-6.4.9-200.fc38.x86_64
|-- System.map-6.5.0-0.rc6.43.fc39.x86_64
|-- config-6.4.10-200.fc38.x86_64
|-- config-6.4.9-200.fc38.x86_64
|-- config-6.5.0-0.rc6.43.fc39.x86_64
|-- efi
|   |-- EFI
|   |   |-- BOOT
|   |   |   |-- BOOTIA32.EFI
|   |   |   |-- BOOTX64.EFI
|   |   |   |-- fbia32.efi
|   |   |   `-- fbx64.efi
|   |   `-- fedora
|   |       |-- BOOTIA32.CSV
|   |       |-- BOOTX64.CSV
|   |       |-- gcdia32.efi
|   |       |-- gcdx64.efi
|   |       |-- grub.cfg
|   |       |-- grubia32.efi
|   |       |-- grubx64.efi
|   |       |-- mmia32.efi
|   |       |-- mmx64.efi
|   |       |-- shim.efi
|   |       |-- shimia32.efi
|   |       `-- shimx64.efi
|   |-- System
|   |   `-- Library
|   |       `-- CoreServices
|   |           `-- SystemVersion.plist
|   `-- mach_kernel
|-- grub2
|   |-- fonts
|   |   `-- unicode.pf2
|   |-- grub.cfg
|   `-- grubenv
|-- initramfs-0-rescue-ce40a64afb9c4524bd6a0f238683ea9a.img
|-- initramfs-6.4.10-200.fc38.x86_64.img
|-- initramfs-6.4.9-200.fc38.x86_64.img
|-- initramfs-6.5.0-0.rc6.43.fc39.x86_64.img
|-- loader
|   `-- entries
|       |-- ce40a64afb9c4524bd6a0f238683ea9a-0-rescue.conf
|       |-- ce40a64afb9c4524bd6a0f238683ea9a-6.4.10-200.fc38.x86_64.conf
|       |-- ce40a64afb9c4524bd6a0f238683ea9a-6.4.9-200.fc38.x86_64.conf
|       `-- ce40a64afb9c4524bd6a0f238683ea9a-6.5.0-0.rc6.43.fc39.x86_64.conf
|-- lost+found
|-- symvers-6.4.10-200.fc38.x86_64.xz -> /lib/modules/6.4.10-200.fc38.x86_64/symvers.xz
|-- symvers-6.4.9-200.fc38.x86_64.xz -> /lib/modules/6.4.9-200.fc38.x86_64/symvers.xz
|-- symvers-6.5.0-0.rc6.43.fc39.x86_64.xz -> /lib/modules/6.5.0-0.rc6.43.fc39.x86_64/symvers.xz
|-- vmlinuz-0-rescue-ce40a64afb9c4524bd6a0f238683ea9a
|-- vmlinuz-6.4.10-200.fc38.x86_64
|-- vmlinuz-6.4.9-200.fc38.x86_64
`-- vmlinuz-6.5.0-0.rc6.43.fc39.x86_64

Additional questions

  • Operating system and version: Fedora 39 beta
  • Have you tried rebooting? Yes
  • Is this a regression? No
  • Are you using an NVMe disk? Yes
  • Is secure boot enabled? Yes
  • Is this a Lenovo system with 'Boot Order Lock' turned on in the BIOS? No
@bbhtt bbhtt added the bug label Aug 18, 2023
@CleoMenezesJr
Copy link

Facing the same here.

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

Hmm, device 362301da643102b9f38477387e2193e57abaa590 clearly exists in the fwupdmgr output. The Failed to build result string comes from plugins/fwupd/gs-plugin-fwupd.c in gnome-software. The latter does fwupd_client_get_results() and gets a valid FwupdDevice and then calls gs_plugin_fwupd_new_app_from_device(). I think the only way this can fail is if somehow the AppStream ID is NULL -- I wonder if you're hitting 3974ea5 too.

Two ways to test -- either downgrade libxmlb, or better, can you test the package in https://copr.fedorainfracloud.org/coprs/rhughes/fwupd/ please?

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

Two ways to test -- either downgrade libxmlb, or better, can you test the package in https://copr.fedorainfracloud.org/coprs/rhughes/fwupd/ please?

I downgraded linxmlb to 0.3.11-3.fc39 manually from koji and also tried fwupd-1.9.4-0.1034.20230814git.fc39.x86_64 from your COPR. Neither seems to work. On restart or doing gnome-software --quit, gnome-software I get the popup again.

Thanks!

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

Can you attach the output of fwupdmgr get-history --json please?

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

Can you attach the output of fwupdmgr get-history --json please?

Output
{
  "Devices" : [
    {
      "Name" : "UEFI dbx",
      "DeviceId" : "362301da643102b9f38477387e2193e57abaa590",
      "Guid" : [
        "c6682ade-b5ec-57c4-b687-676351208742"
      ],
      "Plugin" : "uefi_dbx",
      "Flags" : [
        "internal",
        "updatable",
        "supported",
        "needs-reboot",
        "historical",
        "usable-during-update",
        "only-version-upgrade",
        "signed-payload"
      ],
      "Version" : "371",
      "Created" : 1692361249,
      "Modified" : 1692362745,
      "UpdateState" : 2,
      "Releases" : [
        {
          "RemoteId" : "lvfs",
          "Version" : "371",
          "Filename" : "de143fc38b339d982079517b6f01bcec5246cf5e",
          "Protocol" : "org.uefi.dbx",
          "Checksum" : [
            "bc6a604b29918d67d5fef745ad4375ca3d43d05e"
          ],
          "HostEnclosureKind" : "3",
          "HostSku" : "Default string",
          "DistroVersion" : "39",
          "RuntimeVersion(org.freedesktop.fwupd)" : "1.9.3",
          "RuntimeVersion(org.kernel)" : "6.5.0-0.rc6.43.fc39.x86_64",
          "CpuArchitecture" : "x86_64",
          "UEFIUXCapsule" : "Enabled",
          "SecureBoot" : "Enabled",
          "HostFamily" : "B450 MB",
          "HostBiosVersion" : "F65a",
          "HostVendor" : "Gigabyte Technology Co., Ltd.",
          "RuntimeVersion(org.freedesktop.gusb)" : "0.4.6",
          "KernelName" : "Linux",
          "DistroPrettyName" : "Fedora Linux 39 (Workstation Edition Prerelease)",
          "FwupdSupported" : "True",
          "DistroName" : "Fedora Linux",
          "RuntimeVersion(com.hughsie.libjcat)" : "0.1.14",
          "DistroVariant" : "workstation",
          "KernelVersion" : "6.5.0-0.rc6.43.fc39.x86_64",
          "CompileVersion(org.freedesktop.gusb)" : "0.4.6",
          "HostFirmwareMajorRelease" : "ff",
          "HostProduct" : "B450M DS3H WIFI",
          "BootTime" : "1692361205",
          "RuntimeVersion(org.freedesktop.fwupd-efi)" : "1.4",
          "CpuModel" : "Advanced Micro Devices, Inc. AMD Ryzen 5 5600G with Radeon Graphics",
          "HostBaseboardManufacturer" : "Gigabyte Technology Co., Ltd.",
          "KernelCmdline" : "quiet\n",
          "HostBiosMajorRelease" : "05",
          "HostBiosVendor" : "American Megatrends International, LLC.",
          "CompileVersion(com.hughsie.libxmlb)" : "0.3.11",
          "CompileVersion(com.hughsie.libjcat)" : "0.1.14",
          "HostBaseboardProduct" : "B450M DS3H WIFI-CF",
          "EfivarNvramUsed" : "55293",
          "DistroId" : "fedora",
          "CompileVersion(org.freedesktop.fwupd)" : "1.9.3",
          "HostFirmwareMinorRelease" : "ff",
          "HostBiosMinorRelease" : "11"
        },
        {
          "AppstreamId" : "org.linuxfoundation.dbx.x64.firmware",
          "ReleaseId" : "35287",
          "RemoteId" : "lvfs",
          "Name" : "Secure Boot dbx",
          "NameVariantSuffix" : "x64",
          "Summary" : "UEFI Secure Boot Forbidden Signature Database",
          "Description" : "<p>Insecure versions of the Microsoft Windows boot manager affected by Black Lotus were added to the list of forbidden signatures due to a discovered security problem.This updates the dbx to the latest release from Microsoft.</p><p>Before installing the update, fwupd will check for any affected executables in the ESP and will refuse to update if it finds any boot binaries signed with any of the forbidden signatures.Applying this update may also cause some Windows install media to not start correctly.</p>",
          "Version" : "371",
          "Filename" : "DBXUpdate-20230509-x64.cab",
          "Protocol" : "org.uefi.dbx",
          "Categories" : [
            "X-Configuration",
            "X-System"
          ],
          "Issues" : [
            "CVE-2022-21894"
          ],
          "Checksum" : [
            "bc6a604b29918d67d5fef745ad4375ca3d43d05e",
            "fc3feb015df2710fcfa07583d31b5975ee398357016699cfff067f422ab91e13"
          ],
          "License" : "LicenseRef-proprietary",
          "Size" : 21170,
          "Created" : 1683590400,
          "Locations" : [
            "https://fwupd.org/downloads/fc3feb015df2710fcfa07583d31b5975ee398357016699cfff067f422ab91e13-DBXUpdate-20230509-x64.cab"
          ],
          "Uri" : "https://fwupd.org/downloads/fc3feb015df2710fcfa07583d31b5975ee398357016699cfff067f422ab91e13-DBXUpdate-20230509-x64.cab",
          "Homepage" : "https://uefi.org/revocationlistfile",
          "Vendor" : "Linux Foundation",
          "Flags" : [
            "trusted-metadata",
            "trusted-report"
          ],
          "InstallDuration" : 1,
          "Reports" : [
            {
              "DeviceName" : "FUJITSU CLIENT COMPUTING LIMITED",
              "DistroId" : "fedora",
              "DistroVariant" : "workstation",
              "DistroVersion" : "38",
              "VersionOld" : "211",
              "Vendor" : "DMC Group",
              "RemoteId" : "lvfs",
              "VendorId" : 1758,
              "RuntimeVersion(org.freedesktop.fwupd)" : "1.9.2"
            },
            {
              "DeviceName" : "LENOVO ThinkPad E14 Gen 2",
              "DistroId" : "ubuntu",
              "DistroVersion" : "22.04",
              "VersionOld" : "220",
              "Vendor" : "Jabra",
              "RemoteId" : "lvfs",
              "VendorId" : 21,
              "RuntimeVersion(org.freedesktop.fwupd)" : "1.9.3"
            }
          ]
        }
      ]
    }
  ]
}

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

Weird! There are two 371 releases on the device -- the first has no AppstreamId and the second does. I have no idea how that's happened. Can you attach your /var/lib/fwupd/pending.db please?

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

Weird! There are two 371 releases on the device -- the first has no AppstreamId and the second does. I have no idea how that's happened. Can you attach your /var/lib/fwupd/pending.db please?

Here (GitHub doesn't support .db so I changed it to .txt)

pending.txt

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

Okay, I can reproduce here with that pending database, debugging now --thanks.

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

Bleh, that's just #6103 which is harmless and not the fix for this. It seems that the AppStream ID isn't saved in the database for some reason and somehow we're not fixing it up before returning results to the client. I'm pondering the fix.

hughsie added a commit that referenced this issue Aug 21, 2023
I do not understand how this ever worked before...

Fixes #6101
@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

@bbhtt ^^ fixes it for me. I can do a Fedora COPR package if that helps?

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

@bbhtt ^^ fixes it for me. I can do a Fedora COPR package if that helps?

Thanks, that'd be great

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

@CleoMenezesJr
Copy link

Thank you!

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

@bbhtt COPR updated: https://copr.fedorainfracloud.org/coprs/rhughes/fwupd/build/6324661/

Still getting the warning after updating and rebooting. Is there any additional steps needed?

fwupd.x86_64                                         1.9.4-0.1036.20230821git.fc39     @copr:copr.fedorainfracloud.org:rhughes:fwupd
fwupd-efi.x86_64                                     1.4-1.fc38                        @anaconda                                    
fwupd-plugin-flashrom.x86_64                         1.9.4-0.1036.20230821git.fc39     @copr:copr.fedorainfracloud.org:rhughes:fwupd
fwupd-plugin-modem-manager.x86_64                    1.9.4-0.1036.20230821git.fc39     @copr:copr.fedorainfracloud.org:rhughes:fwupd
fwupd-plugin-uefi-capsule-data.x86_64                1.9.4-0.1036.20230821git.fc39     @copr:copr.fedorainfracloud.org:rhughes:fwupd

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

@bbhtt what's fwupdmgr get-history --json with that version installed?

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

@bbhtt what's fwupdmgr get-history --json with that version installed?

Output
{
  "Devices" : [
    {
      "Name" : "UEFI dbx",
      "DeviceId" : "362301da643102b9f38477387e2193e57abaa590",
      "Guid" : [
        "c6682ade-b5ec-57c4-b687-676351208742"
      ],
      "Plugin" : "uefi_dbx",
      "Flags" : [
        "internal",
        "updatable",
        "supported",
        "needs-reboot",
        "historical",
        "usable-during-update",
        "only-version-upgrade",
        "signed-payload"
      ],
      "Version" : "371",
      "Created" : 1692361249,
      "Modified" : 1692362745,
      "UpdateState" : 2,
      "Releases" : [
        {
          "AppstreamId" : "org.linuxfoundation.dbx.x64.firmware",
          "RemoteId" : "lvfs",
          "Version" : "371",
          "Filename" : "de143fc38b339d982079517b6f01bcec5246cf5e",
          "Protocol" : "org.uefi.dbx",
          "Checksum" : [
            "bc6a604b29918d67d5fef745ad4375ca3d43d05e"
          ],
          "HostEnclosureKind" : "3",
          "HostSku" : "Default string",
          "DistroVersion" : "39",
          "RuntimeVersion(org.freedesktop.fwupd)" : "1.9.3",
          "RuntimeVersion(org.kernel)" : "6.5.0-0.rc6.43.fc39.x86_64",
          "CpuArchitecture" : "x86_64",
          "UEFIUXCapsule" : "Enabled",
          "SecureBoot" : "Enabled",
          "HostFamily" : "B450 MB",
          "HostBiosVersion" : "F65a",
          "HostVendor" : "Gigabyte Technology Co., Ltd.",
          "RuntimeVersion(org.freedesktop.gusb)" : "0.4.6",
          "KernelName" : "Linux",
          "DistroPrettyName" : "Fedora Linux 39 (Workstation Edition Prerelease)",
          "FwupdSupported" : "True",
          "DistroName" : "Fedora Linux",
          "RuntimeVersion(com.hughsie.libjcat)" : "0.1.14",
          "DistroVariant" : "workstation",
          "KernelVersion" : "6.5.0-0.rc6.43.fc39.x86_64",
          "CompileVersion(org.freedesktop.gusb)" : "0.4.6",
          "HostFirmwareMajorRelease" : "ff",
          "HostProduct" : "B450M DS3H WIFI",
          "BootTime" : "1692361205",
          "RuntimeVersion(org.freedesktop.fwupd-efi)" : "1.4",
          "CpuModel" : "Advanced Micro Devices, Inc. AMD Ryzen 5 5600G with Radeon Graphics",
          "HostBaseboardManufacturer" : "Gigabyte Technology Co., Ltd.",
          "KernelCmdline" : "quiet\n",
          "HostBiosMajorRelease" : "05",
          "HostBiosVendor" : "American Megatrends International, LLC.",
          "CompileVersion(com.hughsie.libxmlb)" : "0.3.11",
          "CompileVersion(com.hughsie.libjcat)" : "0.1.14",
          "HostBaseboardProduct" : "B450M DS3H WIFI-CF",
          "EfivarNvramUsed" : "55293",
          "DistroId" : "fedora",
          "CompileVersion(org.freedesktop.fwupd)" : "1.9.3",
          "HostFirmwareMinorRelease" : "ff",
          "HostBiosMinorRelease" : "11"
        }
      ]
    }
  ]
}

@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

okay, that's setting AppstreamId" : "org.linuxfoundation.dbx.x64.firmware like I expected now -- are you sure you restarted gnome-software? What gnome-software version are you using?

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

okay, that's setting AppstreamId" : "org.linuxfoundation.dbx.x64.firmware like I expected now -- are you sure you restarted gnome-software? What gnome-software version are you using?

gnome-software 45.beta

I rebooted after updating but doing a --quit and starting it again, pops up the warning

reinstalling the db doesn't work either

hughsie added a commit that referenced this issue Aug 21, 2023
I do not understand how this ever worked before...

Fixes #6101
@hughsie
Copy link
Member

hughsie commented Aug 21, 2023

okay, that's setting AppstreamId" : "org.linuxfoundation.dbx.x64.firmware like I expected now

Aha, but gnome-software isn't using get-history, it's using get-results! I've extended the fix to fix up both cases. There's a new rpm building in the COPR now, you need fwupd release fwupd-1.9.4-0.1037.20230821git.fc38

@bbhtt
Copy link
Author

bbhtt commented Aug 21, 2023

okay, that's setting AppstreamId" : "org.linuxfoundation.dbx.x64.firmware like I expected now

Aha, but gnome-software isn't using get-history, it's using get-results! I've extended the fix to fix up both cases. There's a new rpm building in the COPR now, you need fwupd release fwupd-1.9.4-0.1037.20230821git.fc38

Thanks a lot! That fixes it for me.

hughsie added a commit that referenced this issue Aug 21, 2023
I do not understand how this ever worked before...

Fixes #6101
@pwithnall
Copy link
Collaborator

Thanks @hughsie! That was a fast turnaround

@romulasry
Copy link

I am getting this on Wed Aug 23 at at approximately 11 AM Pacific Daylight Savings time. Fedora rawhide currently- all up to date.

@AdamWill
Copy link

@romulasry what does rpm -q fwupd say?

@romulasry
Copy link

@AdamWill
fwupd-1.9.3-1.fc39.x86_64

@AdamWill
Copy link

The fix is in 1.9.4-1 , you'll need to update to that. It was built August 22 and would have been in the August 23 nightly compose, your update was probably just too soon.

@francesco-ballarin
Copy link

Hi @hughsie,
I am getting a similar problem with debian trixie.

Detailed errors from the package manager follow:

failed to build result for c085a3cbf4dc1d60d110b76168
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux trixie/sid
Release:	n/a
Codename:	trixie
$ fwupdmgr --version
compile   org.freedesktop.fwupd         1.9.4
compile   com.hughsie.libxmlb           0.3.10
compile   com.hughsie.libjcat           0.1.9
runtime   org.freedesktop.fwupd-efi     1.4
compile   org.freedesktop.gusb          0.4.5
runtime   com.dell.libsmbios            2.4
runtime   org.freedesktop.gusb          0.4.5
runtime   org.kernel                    6.4.0-3-amd64
runtime   org.freedesktop.fwupd         1.9.4
$ fwupdmgr get-history --json
{
  "Devices" : [
    {
      "Name" : "Embedded Controller",
      "DeviceId" : "c085a3cbf4dc1d60d110b7616816e2ffd279b64e",
      "Guid" : [
        "f72e048b-65bd-4e71-9071-1ac7045223e5"
      ],
      "Plugin" : "uefi_capsule",
      "Flags" : [
        "internal",
        "updatable",
        "require-ac",
        "needs-reboot",
        "reported",
        "historical",
        "usable-during-update"
      ],
      "Version" : "0.1.2",
      "Created" : 1637485252,
      "Modified" : 1637485281,
      "UpdateState" : 2,
      "Releases" : [
        {
          "Version" : "0.1.25",
          "Checksum" : [
            "ee91745253df4d875399c03fb793966d83a30432"
          ],
          "RuntimeVersion(org.freedesktop.gusb)" : "0.3.8",
          "HostFamily" : "ThinkPad X1 Carbon 7th",
          "BootMgrDesc" : "legacy",
          "CompileVersion(com.redhat.fwupdate)" : "12",
          "LastAttemptStatus" : "0x0",
          "SecureBoot" : "Disabled",
          "LinuxLockdown" : "none",
          "EspPath" : "/boot/efi",
          "UEFIUXCapsule" : "Enabled",
          "RuntimeVersion(com.redhat.fwupdate)" : "12",
          "MissingCapsuleHeader" : "False",
          "RuntimeVersion(org.kernel)" : "5.14.0-4-amd64",
          "CompileVersion(org.freedesktop.gusb)" : "0.3.5",
          "RuntimeVersion(com.dell.libsmbios)" : "2.4",
          "DistroId" : "debian",
          "CpuArchitecture" : "x86_64",
          "BootTime" : "1637485242",
          "HostVendor" : "LENOVO",
          "EfivarNvramUsed" : "43516",
          "RuntimeVersion(org.freedesktop.appstream-glib)" : "0.7.14",
          "KernelVersion" : "5.14.0-4-amd64",
          "HostProduct" : "20QD00LKIX",
          "LastAttemptVersion" : "0x0",
          "TpmFamily" : "2.0",
          "HostSku" : "LENOVO_MT_20QD_BU_Think_FM_ThinkPad X1 Carbon 7th",
          "RuntimeVersion(org.freedesktop.fwupd)" : "1.5.7",
          "CompileVersion(org.freedesktop.fwupd)" : "1.5.7"
        }
      ]
    },
    {
      "Name" : "UEFI dbx",
      "DeviceId" : "362301da643102b9f38477387e2193e57abaa590",
      "Guid" : [
        "14503b3d-73ce-5d06-8137-77c68972a341"
      ],
      "Plugin" : "uefi_dbx",
      "Flags" : [
        "internal",
        "updatable",
        "supported",
        "needs-reboot",
        "historical",
        "usable-during-update",
        "only-version-upgrade",
        "signed-payload"
      ],
      "Version" : "217",
      "Created" : 1693395599,
      "Modified" : 1693395949,
      "UpdateState" : 2,
      "Releases" : [
        {
          "AppstreamId" : "org.linuxfoundation.dbx.x64.firmware",
          "RemoteId" : "lvfs",
          "Version" : "371",
          "Filename" : "de143fc38b339d982079517b6f01bcec5246cf5e",
          "Protocol" : "org.uefi.dbx",
          "Checksum" : [
            "bc6a604b29918d67d5fef745ad4375ca3d43d05e"
          ],
          "HostEnclosureKind" : "a",
          "HostSku" : "LENOVO_MT_20QD_BU_Think_FM_ThinkPad X1 Carbon 7th",
          "RuntimeVersion(org.freedesktop.fwupd)" : "1.9.4",
          "RuntimeVersion(org.kernel)" : "6.4.0-3-amd64",
          "BootMgrDesc" : "legacy",
          "UEFIUXCapsule" : "Enabled",
          "CpuArchitecture" : "x86_64",
          "SecureBoot" : "Disabled",
          "HostFamily" : "ThinkPad X1 Carbon 7th",
          "HostBiosVersion" : "N2HET30W (1.13 )",
          "HostVendor" : "LENOVO",
          "RuntimeVersion(org.freedesktop.gusb)" : "0.4.5",
          "KernelName" : "Linux",
          "DistroPrettyName" : "Debian GNU/Linux trixie/sid",
          "RuntimeVersion(com.dell.libsmbios)" : "2.4",
          "DistroName" : "Debian GNU/Linux",
          "FwupdSupported" : "True",
          "KernelVersion" : "6.4.0-3-amd64",
          "CompileVersion(org.freedesktop.gusb)" : "0.4.5",
          "HostFirmwareMajorRelease" : "01",
          "HostProduct" : "20QD00LKIX",
          "BootTime" : "1693395574",
          "RuntimeVersion(org.freedesktop.fwupd-efi)" : "1.4",
          "CpuModel" : "Intel Core™ i7-8565U CPU @ 1.80GHz",
          "HostBaseboardManufacturer" : "LENOVO",
          "HostBiosMajorRelease" : "01",
          "HostBiosVendor" : "LENOVO",
          "CompileVersion(com.hughsie.libxmlb)" : "0.3.10",
          "CompileVersion(com.hughsie.libjcat)" : "0.1.9",
          "EfivarNvramUsed" : "52331",
          "HostBaseboardProduct" : "20QD00LKIX",
          "DistroId" : "debian",
          "HostFirmwareMinorRelease" : "19",
          "CompileVersion(org.freedesktop.fwupd)" : "1.9.4",
          "HostBiosMinorRelease" : "0d"
        }
      ]
    }
  ]
}

Thanks.

@hughsie
Copy link
Member

hughsie commented Aug 30, 2023

failed to build result for c085a3cbf4dc1d60d110b76168

Exactly that? That hash seems truncated,

@francesco-ballarin
Copy link

Apologies, I must have truncated it in the copy and paste

Detailed errors from the package manager follow:

failed to build result for c085a3cbf4dc1d60d110b7616816e2ffd279b64e

@hughsie
Copy link
Member

hughsie commented Aug 30, 2023

@francesco-ballarin what does fwupdmgr get-results c085a3cbf4dc1d60d110b7616816e2ffd279b64e --json say for you?

@francesco-ballarin
Copy link

$ fwupdmgr get-results c085a3cbf4dc1d60d110b7616816e2ffd279b64e --json
{
  "Error" : {
    "Domain" : "FwupdError",
    "Code" : 8,
    "Message" : "failed to find c085a3cbf4dc1d60d110b7616816e2ffd279b64e"
  }
}

@hughsie
Copy link
Member

hughsie commented Aug 30, 2023

And fwupdmgr get-devices please?

@francesco-ballarin
Copy link

$ fwupdmgr get-devices
LENOVO 20QD00LKIX
│
├─Core™ i7-8565U CPU @ 1.80GHz:
│     Device ID:          4bde70ba4e39b28f9eab1628f9dd6e6244c03027
│     Current version:    0x000000b8
│     Vendor:             Intel
│     GUIDs:              b9a2dd81-159e-5537-a7db-e7101d164d3f ← cpu
│                         30249f37-d140-5d3e-9319-186b1bd5cac3 ← CPUID\PRO_0&FAM_06
│                         561403e8-143a-5071-ab09-bf5e4c146983 ← CPUID\PRO_0&FAM_06&MOD_8E
│                         d5092916-1868-5182-8c70-12f83dab6372 ← CPUID\PRO_0&FAM_06&MOD_8E&STP_C
│     Device Flags:       • Internal device
│   
├─Embedded Controller:
│     Device ID:          2292ae5236790b47884e37cf162dcf23bfcd1c60
│     Summary:            UEFI ESRT device
│     Current version:    0.1.25
│     Minimum Version:    0.1.25
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     Problems:           • Device requires AC power to be connected
│     GUID:               f72e048b-65bd-4e71-9071-1ac7045223e5
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Updatable
│   
├─Intel Management Engine:
│     Device ID:          349bb341230b1a86e5effe7dfe4337e1590227bd
│     Summary:            UEFI ESRT device
│     Current version:    192.47.1524
│     Minimum Version:    0.0.1
│     Vendor:             Lenovo (DMI:LENOVO)
│     Update State:       Success
│     Problems:           • Device requires AC power to be connected
│     GUID:               c3e4be53-e714-4ea1-bb9c-7fe13a98b556
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Updatable
│   
├─System Firmware:
│ │   Device ID:          a45df35ac0e948ee180fe216a5f703f32dda163f
│ │   Summary:            UEFI ESRT device
│ │   Current version:    0.1.13
│ │   Minimum Version:    0.0.1
│ │   Vendor:             Lenovo (DMI:LENOVO)
│ │   Update State:       Success
│ │   Problems:           • Device requires AC power to be connected
│ │   GUIDs:              4bbc40fa-f81e-4206-bc70-a1f7b744d964
│ │                       230c8b18-8d9b-53ec-838b-6cfc0383493a ← main-system-firmware
│ │   Device Flags:       • Internal device
│ │                       • System requires external power source
│ │                       • Needs a reboot after installation
│ │                       • Cryptographic hash verification is available
│ │                       • Device is usable for the duration of the update
│ │                       • Updatable
│ │ 
│ └─UEFI dbx:
│       Device ID:        362301da643102b9f38477387e2193e57abaa590
│       Summary:          UEFI revocation database
│       Current version:  371
│       Minimum Version:  371
│       Vendor:           UEFI:Linux Foundation
│       Install Duration: 1 second
│       GUIDs:            14503b3d-73ce-5d06-8137-77c68972a341 ← UEFI\CRT_A9087D1044AD18F7A94916D284CBC01827CF23CD8F60B79072C9CAA1FEF4D649
│                         5971a208-da00-5fce-b5f5-1234342f9cf7 ← UEFI\CRT_A9087D1044AD18F7A94916D284CBC01827CF23CD8F60B79072C9CAA1FEF4D649&ARCH_X64
│                         c6682ade-b5ec-57c4-b687-676351208742 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503
│                         f8ba2887-9411-5c36-9cee-88995bb39731 ← UEFI\CRT_A1117F516A32CEFCBA3F2D1ACE10A87972FD6BBE8FE0D0B996E09E65D802A503&ARCH_X64
│       Device Flags:     • Internal device
│                         • Updatable
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Only version upgrades are allowed
│                         • Signed Payload
│     
├─TPM:
│     Device ID:          c6a80ac3a22083423992a3cb15018989f37834d6
│     Current version:    73.8.17568.5511
│     Vendor:             ST Microelectronics (TPM:STM)
│     Problems:           • Device requires AC power to be connected
│     GUIDs:              ff71992e-52f7-5eea-94ef-883e56e034c6 ← system-tpm
│                         84df3581-f896-54d2-bd1a-372602f04c32 ← TPM\VEN_STM&DEV_0001
│                         bfaed10a-bbc1-525b-a329-35da2f63e918 ← TPM\VEN_STM&MOD_
│                         70b7b833-7e1a-550a-a291-b94a12d0f319 ← TPM\VEN_STM&DEV_0001&VER_2.0
│                         06f005e9-cb62-5d1a-82d9-13c534c53c48 ← TPM\VEN_STM&MOD_&VER_2.0
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device can recover flash failures
│                         • Updatable
│                         • Full disk encryption secrets may be invalidated when updating
│                         • Signed Payload
│   
├─Thunderbolt host controller:
│     Device ID:          9a546be6a2ad7048ab457e58b2e739d1caf754e2
│     Summary:            Unmatched performance for high-speed I/O
│     Current version:    47.00
│     Vendor:             Lenovo (THUNDERBOLT:0x0109, TBT:0x0109)
│     Problems:           • Device requires AC power to be connected
│     GUIDs:              18bb00e3-5d7a-55d3-831e-0e000c184b0e ← THUNDERBOLT\VEN_0109&DEV_1801
│                         c7920601-0cda-507f-851e-92229eb1d370 ← TBT-01091801-native
│                         96c6512b-0138-51da-b02f-f44f2c4c7744 ← TBT-01091801-native-controller0-0
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Supported on remote server
│                         • Device stages updates
│                         • Updatable
│                         • Signed Payload
│   
├─UEFI Device Firmware:
│     Device ID:          f95c9218acd12697af946874bfe4239587209232
│     Summary:            UEFI ESRT device
│     Current version:    16785559
│     Minimum Version:    1
│     Vendor:             DMI:LENOVO
│     Update State:       Success
│     Problems:           • Device requires AC power to be connected
│     GUID:               9045ae09-34ab-46d6-826d-b02f859dd20b
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Updatable
│   
├─UEFI Device Firmware:
│     Device ID:          d96de5c124b60ed6241ebcb6bb2c839cb5580786
│     Summary:            UEFI ESRT device
│     Current version:    26918
│     Minimum Version:    1
│     Vendor:             DMI:LENOVO
│     Update State:       Success
│     Problems:           • Device requires AC power to be connected
│     GUID:               68d3b08f-6ed2-43ca-86f0-f1ad6e41b390
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Updatable
│   
├─WDC PC SN720 SDAQNTW-512G-1001:
│     Device ID:          3743975ad7f64f8d6575a9ae49fb3a8856fe186f
│     Summary:            NVM Express solid state drive
│     Current version:    10190101
│     Vendor:             Sandisk Corp (NVME:0x15B7)
│     Serial Number:      19275C805072
│     Problems:           • Device requires AC power to be connected
│     GUIDs:              ff2112dc-038c-596d-90ca-d43c5077c6ec ← NVME\VEN_15B7&DEV_5002
│                         c528df4b-7972-5880-8cb1-330415e2dc6a ← NVME\VEN_15B7&DEV_5002&SUBSYS_15B75002
│                         63af1441-fb24-5368-b450-886fbc98610b ← WDC PC SN720 SDAQNTW-512G-1001
│     Device Flags:       • Internal device
│                         • System requires external power source
│                         • Supported on remote server
│                         • Needs a reboot after installation
│                         • Device is usable for the duration of the update
│                         • Updatable
│   
└─WhiskeyLake-U GT2 [UHD Graphics 620]:
      Device ID:          5792b48846ce271fab11c4a545f7a3df0d36e00a
      Current version:    02
      Vendor:             Intel Corporation (PCI:0x8086)
      GUIDs:              52aa8ac7-c837-561f-af32-b7979cd2f6ed ← PCI\VEN_8086&DEV_3EA0
                          4cf1c502-32ec-5639-85c3-5343edba4731 ← PCI\VEN_8086&DEV_3EA0&SUBSYS_17AA2292
      Device Flags:       • Internal device
                          • Cryptographic hash verification is available
    
────────────────────────────────────────────────
Devices that have been updated successfully:
 • UEFI dbx (217 → 371)

@hughsie
Copy link
Member

hughsie commented Aug 30, 2023

@francesco-ballarin so weirdly the embedded controller is now 2292ae5236790b47884e37cf162dcf23bfcd1c60 -- the device ID should have been static -- is it possible you updated the embedded controller with a much older version of fwupd?

@francesco-ballarin
Copy link

is it possible you updated the embedded controller with a much older version of fwupd

I did update fwupd from 1.9.3 to 1.9.4 today, but probably that doesn't qualify as much older. I did have an update UEFI dbx, but I don't know how to check if that happened with 1.9.3 or 1.9.4, but that is probably unrelated to the embedded controller.

@hughsie
Copy link
Member

hughsie commented Aug 30, 2023

Ahh, get-history has: "RuntimeVersion(org.freedesktop.fwupd)" : "1.5.7", -- that's much older than 1.9.3. I think fwupd should probably filter out the devices that no longer exist when doing get_results with the FWUPD_DEVICE_ID_ANY mask. Can you open a new issue please and I'll fix that one this week.

@hughsie
Copy link
Member

hughsie commented Aug 30, 2023

@francesco-ballarin also, what gnome-software version pls?

@francesco-ballarin
Copy link

gnome-software version pls?

gnome-software 45.beta

Can you open a new issue please and I'll fix that one this week.

Thanks! Issue is #6128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

7 participants