New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flashrom: switch to upstream source #1327
Conversation
Is all the stuff upstream now? I thought there was some stuff that was pending still? |
I'm not sure - is there something tracking the PR that were open? Maybe some pings are needed if some are still out there. |
From my glancing I guess these are the ones that should land first before switching to upstream sources: |
I've poked the right people at OSFC today. |
@@ -22,6 +22,8 @@ | |||
#include "config.h" | |||
|
|||
#include <string.h> | |||
#include <stdbool.h> | |||
#include <stdint.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed once https://review.coreboot.org/c/flashrom/+/35155 merged
ab40788
to
042e2fa
Compare
Those were both merged, so I think this can be updated now. Still in flight is this one: https://review.coreboot.org/c/flashrom/+/35559 and once that's done and tagged, we should set a minimum version at 1.2 and turn this on by default. |
When that's in, LGTM, thanks. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Last remaining one: https://review.coreboot.org/c/flashrom/+/35561 |
Nearly there! If we can get everything in, then convince them to do a new tarball I can switch fedora to using the meson build. I assume the meson files get included in an automake make dist? |
Looks like they should be there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more to go, and then LGTM, thanks!
Do you have someone you can ping over there? |
042e2fa
to
278d468
Compare
Once upstream flashrom tags a release (>1.1) this should be updated and as it starts to flow into distros turned on by default.
278d468
to
496046f
Compare
Okay all up to upstream version. Going to merge this now, and once they tag a release we can set to enabled by default. |
Once upstream flashrom tags a release (>1.1) this should be updated
and as it starts to flow into distros turned on by default.
Type of pull request: