Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashrom: switch to upstream source #1327

Merged
merged 1 commit into from Nov 6, 2019
Merged

Conversation

superm1
Copy link
Member

@superm1 superm1 commented Aug 29, 2019

Once upstream flashrom tags a release (>1.1) this should be updated
and as it starts to flow into distros turned on by default.

Type of pull request:

@hughsie
Copy link
Member

hughsie commented Sep 1, 2019

Is all the stuff upstream now? I thought there was some stuff that was pending still?

@superm1
Copy link
Member Author

superm1 commented Sep 1, 2019

I'm not sure - is there something tracking the PR that were open? Maybe some pings are needed if some are still out there.

@superm1
Copy link
Member Author

superm1 commented Sep 3, 2019

From my glancing I guess these are the ones that should land first before switching to upstream sources:

@hughsie
Copy link
Member

hughsie commented Sep 3, 2019

I've poked the right people at OSFC today.

@@ -22,6 +22,8 @@
#include "config.h"

#include <string.h>
#include <stdbool.h>
#include <stdint.h>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superm1 superm1 force-pushed the wip/superm1/upstream-flashrom branch from ab40788 to 042e2fa Compare September 24, 2019 13:46
@superm1
Copy link
Member Author

superm1 commented Sep 24, 2019

Those were both merged, so I think this can be updated now.

Still in flight is this one: https://review.coreboot.org/c/flashrom/+/35559 and once that's done and tagged, we should set a minimum version at 1.2 and turn this on by default.

@hughsie
Copy link
Member

hughsie commented Sep 24, 2019

When that's in, LGTM, thanks.

@superm1

This comment has been minimized.

@superm1

This comment has been minimized.

@superm1
Copy link
Member Author

superm1 commented Oct 24, 2019

Last remaining one: https://review.coreboot.org/c/flashrom/+/35561

@hughsie
Copy link
Member

hughsie commented Oct 24, 2019

Nearly there! If we can get everything in, then convince them to do a new tarball I can switch fedora to using the meson build. I assume the meson files get included in an automake make dist?

@superm1
Copy link
Member Author

superm1 commented Oct 24, 2019

Nearly there! If we can get everything in, then convince them to do a new tarball I can switch fedora to using the meson build. I assume the meson files get included in an automake make dist?

Looks like they should be there:
https://review.coreboot.org/plugins/gitiles/flashrom/+/refs/heads/master/Makefile#1495

Copy link
Member

@hughsie hughsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more to go, and then LGTM, thanks!

@superm1
Copy link
Member Author

superm1 commented Oct 30, 2019

One more to go, and then LGTM, thanks!

Do you have someone you can ping over there?

@hughsie hughsie added this to the 1.3.4 milestone Nov 1, 2019
@superm1 superm1 force-pushed the wip/superm1/upstream-flashrom branch from 042e2fa to 278d468 Compare November 6, 2019 13:29
Once upstream flashrom tags a release (>1.1) this should be updated
and as it starts to flow into distros turned on by default.
@superm1 superm1 force-pushed the wip/superm1/upstream-flashrom branch from 278d468 to 496046f Compare November 6, 2019 13:45
@superm1
Copy link
Member Author

superm1 commented Nov 6, 2019

Okay all up to upstream version. Going to merge this now, and once they tag a release we can set to enabled by default.

@superm1 superm1 merged commit 85fb312 into master Nov 6, 2019
@superm1 superm1 deleted the wip/superm1/upstream-flashrom branch November 6, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants