libfwupdplugin: Implement fu-efivar-freebsd.c #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Hughes <richard@hughsie.com>
4 tasks
superm1
reviewed
Jun 9, 2021
| elif host_machine.system() == 'windows' | ||
| fwupdplugin_src += 'fu-common-windows.c' | ||
| fwupdplugin_src += 'fu-efivar-windows.c' # fuzzing |
There was a problem hiding this comment.
by splitting this way I don't think this code will ever be fuzzed
There was a problem hiding this comment.
That was intentional; i.e. we don't actually link giounix into the fuzzer binary. We certainly could, but the efivar parsing isn't something that lends itself to fuzzing.
superm1
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Hughes richard@hughsie.com
Type of pull request: