Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/hughsie/size #3981

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Wip/hughsie/size #3981

merged 3 commits into from
Nov 12, 2021

Conversation

hughsie
Copy link
Member

@hughsie hughsie commented Nov 12, 2021

Type of pull request:

@hughsie hughsie requested a review from superm1 November 12, 2021 16:37
@hughsie hughsie self-assigned this Nov 12, 2021
@hughsie
Copy link
Member Author

hughsie commented Nov 12, 2021

@rossburton FYI

superm1
superm1 reviewed Nov 12, 2021
View reviewed changes
data/meson.build Show resolved Hide resolved
meson_options.txt Outdated Show resolved Hide resolved
superm1
superm1 previously approved these changes Nov 12, 2021
View reviewed changes
@hughsie
Use -Doffline=false to reduce the install size by over 100Kb
c513dad 
If there's no SuperIO chip then there's no need to support this.
@hughsie hughsie merged commit 5f01678 into main Nov 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the wip/hughsie/size branch November 12, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superm1 superm1 superm1 left review comments

Assignees

@hughsie hughsie

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hughsie @superm1