fu-smbios: Fix parsing smbios data #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsie
reviewed
Jul 20, 2022
When support was added for falling back to SMBIOS data from the kernel in /sys/class/dmi, we inadvertently stopped caring about the data parsed directly from DMI tables as first priority. This caused a regression in hwids from some OEMs that relied upon IDs that could only be properly built from DMI tables, not the kernel /sys/class/dmi interface. Link: https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1982103 Fixes: 464425f ("SMBIOS: try reading from /sys/class/dmi if direct access fails") Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
superm1
force-pushed
the
mlimonci/fix-smbios
branch
from
47bddc6
to
b1cc2d9
Compare
hughsie
approved these changes
Jul 20, 2022
Sure. It's kinda a bad one. Between that and the one with the devone (and anything based off Insyde really) being broken, care for a new fixup release? |
Planned for Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When support was added for falling back to SMBIOS data from the kernel
in /sys/class/dmi, we inadvertently stopped caring about the data parsed
directly from DMI tables as first priority. This caused a regression in
hwids from some OEMs that relied upon IDs that could only be properly built
from DMI tables, not the kernel /sys/class/dmi interface.
Link: https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1982103
Fixes: 464425f ("SMBIOS: try reading from /sys/class/dmi if direct access fails")
Signed-off-by: Mario Limonciello mario.limonciello@amd.com
Type of pull request: