Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: allow fwupdmgr to shutdown #5513

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

valentindavid
Copy link
Collaborator

When installing a capsule, optional reboot is done by fwupdmgr instead of fwupd. This means fwupdmgr needs the permission to do that.

Type of pull request:

When installing a capsule, optional reboot is done by fwupdmgr instead
of fwupd. This means fwupdmgr needs the permission to do that.
@hughsie
Copy link
Member

hughsie commented Feb 10, 2023

It sometimes also needs reboot instead, is that the same permission?

@valentindavid
Copy link
Collaborator Author

shutdown interface includes reboot. Here is the AppArmor profile for it.

dbus (send)
    bus=system
    path=/org/freedesktop/systemd1
    interface=org.freedesktop.systemd1.Manager
    member={Reboot,PowerOff,Halt}
    peer=(label=unconfined),

dbus (send)
    bus=system
    path=/org/freedesktop/login1
    interface=org.freedesktop.login1.Manager
    member={PowerOff,Reboot,Suspend,Hibernate,HybridSleep,CanPowerOff,CanReboot,CanSuspend,CanHibernate,CanHybridSleep,ScheduleShutdown,CancelScheduledShutdown,SetWallMessage}
    peer=(label=unconfined),

@superm1 superm1 merged commit d911ca6 into fwupd:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants