Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 'pending' firmware with fixable problems when using 'fwupdmgr up… #6856

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

hughsie
Copy link
Member

@hughsie hughsie commented Feb 28, 2024

…date'

Fixes #6853

Type of pull request:

@hughsie
Copy link
Member Author

hughsie commented Feb 28, 2024

Screenshot from 2024-02-28 12-15-32

@hughsie
Copy link
Member Author

hughsie commented Feb 28, 2024

@mcatanzaro would something like the screenshot above have helped?

@Conan-Kudo
Copy link

Does this change anything for GNOME Software or Plasma Discover?

@superm1
Copy link
Member

superm1 commented Feb 28, 2024

Does this change anything for GNOME Software or Plasma Discover?

Those are independent bugs with those projects and should be filed there.

@hughsie
Copy link
Member Author

hughsie commented Feb 28, 2024

Does this change anything for GNOME Software or Plasma Discover?

Na. We cleverly (read: accidentally) stop behavior changes as we ask the client "what are you able to handle" -- so if a client sets FWUPD_FEATURE_FLAG_SHOW_PROBLEMS then we return results from the dbus methods like GetUpdates that can't actually be deployed at the moment, on the logic that older clients that don't know about checking for problems won't have that set.

But yes, as @superm1 says we need to fix that in those projects.

@mcatanzaro
Copy link

I've reported this issue for GNOME Software.

@Conan-Kudo please consider reporting a Plasma Discover bug.

would something like the screenshot above have helped?

If it works without having to add the --force flag to show the unavailable updates, then yes.

It's fine to refuse to install available updates. Just not good to refuse to show them.

superm1
superm1 previously approved these changes Feb 28, 2024
Copy link
Member

@superm1 superm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit on the string to use for this, otherwise okay.

src/fu-tool.c Outdated Show resolved Hide resolved
@Conan-Kudo
Copy link

I've reported this issue for GNOME Software.

@Conan-Kudo please consider reporting a Plasma Discover bug.

This is done now. FYI @aleixpol

@hughsie hughsie merged commit 5c565bd into main Feb 28, 2024
19 checks passed
@hughsie hughsie deleted the hughsie/fwupdmgr-update-msgs branch February 28, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants