Hughsie/19x backports #7297
Merged
Hughsie/19x backports #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hughsie, I would take the change about the CounterpartUuid only as I need to find a way to force the mouse of the dongle to boot into the bootloader mode to verify it still works properly. EDIT; well, if in fact it should not hurt to merge the change about the bootloader flag. |
hughsie
force-pushed
the
hughsie/19x-backports
branch
from
fbbf4db
to
b97e49b
Compare
superm1
force-pushed
the
hughsie/19x-backports
branch
from
b97e49b
to
cd54a17
Compare
The is-bootloader flag is not a private flag; use fu_device_has_flag() to check for that flag instead. Fixes: 07:50:11.938 FuDevice FuSteelseriesFizz flag 0x2000 is unknown -- use fu_device_register_private_flag() 07:50:11.940 FuDevice FuSteelseriesFizz flag 0x2000 is unknown -- use fu_device_register_private_flag() (cherry picked from commit 256a4a5)
Fixes: 07:50:12.106 FuEngine steelseries [aa4b7bf130da693bbf1a8a785ad830190788233b] does not declare signed/unsigned payload -- perhaps add fu_device_add_flag(device, FWUPD_DEVICE_FLAG_UNSIGNED_PAYLOAD); (cherry picked from commit 8cccaf6)
(cherry picked from commit 47d89dc)
(cherry picked from commit 49a446d)
(cherry picked from commit b41fb4f)
Arch doesn't install to `$PATH` (cherry picked from commit 04e18f8)
This case isn't really possible anymore since plugins are builtin now. (cherry picked from commit 261494c)
(cherry picked from commit edab17a)
If we fix the strsplit function to do the right thing the CSV parser has to copy what the SREC and Intel HEX parsers already do. (cherry picked from commit db5ebe7)
hughsie
force-pushed
the
hughsie/19x-backports
branch
from
cd54a17
to
a2d3e18
Compare
superm1
approved these changes
Jun 13, 2024
gportay
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request: