Add 'pixart-rf-GCBBTM25.json' for device tests. #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superm1
reviewed
Jun 12, 2024
Support GCBBTM25 BT mouse.
sam412081go
force-pushed
the
pixart_device_tests
branch
from
359bca2
to
dcaf160
Compare
Added. |
superm1
reviewed
Jun 13, 2024
| "interactive": false, | ||
| "steps": [ | ||
| { | ||
| "url": "https://www.fwupd.org/downloads/c5b40f0e4a425c7332513e099a4fd8600feb33e1893b590156fafdbbfe8f0929-GCBBTM25_v0001.cab", |
There was a problem hiding this comment.
This should be emulation-url, no?
superm1
reviewed
Jun 13, 2024
| ] | ||
| }, | ||
| { | ||
| "url": "https://www.fwupd.org/downloads/b6bfa9c1f47252fb28d67bc3bf65bb9f11e2a3c1a32645450efdbdb64350c3c4-GCBBTM25_v0100.cab", |
There was a problem hiding this comment.
This should be emulation-url, no?
There was a problem hiding this comment.
Due to some issues with the emulation data(#7330), it hasn't been uploaded yet.I will prepare the hardware to hughsie for debug.
So, there's only a link to the cab currently. Is the emulation URL necessary?
There was a problem hiding this comment.
Oh I see. Then yes this is sensible for now and once emulation data is fixed that URL can add later.
Thanks!
superm1
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support GCBBTM25 BT mouse.
Type of pull request: